Differential D7338
Disconnect objdump from the build Authored by emaste on Jul 27 2016, 6:45 PM. Tags None Referenced Files
Details
The in-tree binutils is old and will not be updated. Other tools are migrating to copyfree alternatives but there is not yet a direct replacement for objdump. Just remove it as it is not used by the build, and updated and maintained versions are available from ports and packages. Note: Will not be committed prior to 11.0 being released.
Diff Detail
Event TimelineComment Actions ObsoleteFiles.inc to be updated as well prior to commit. Not done yet as conflicts would be encountered on each rebase. Comment Actions Note that llvm-objdump is starting to gain features currently missing compared to GNU objdump -- most importantly, -S (mixed source and disassembly) was recently added. Comment Actions Note there is a consumer in ports Mk/bsd/port.mk: security-check: ${TMPPLIST}
# Scan PLIST for:
...
# 2. accept()/recvfrom() which indicates network listening capability
# 3. insecure functions (gets/mktemp/tempnam/[XXX])
# 4. startup scripts, in conjunction with 2.
...
| ${XARGS} -0 -n 1 ${OBJDUMP} -R 2> /dev/null > ${WRKDIR}/.PLIST.objdump; \
...We can use readelf -r as a replacement for objdump -R, although readelf -Ws | sed -En 's/^.* UND ([^@]+).*$/\1/p' might be more suitable. There are also instances of ${OBJDUMP} in the Makefiles for graphics/OpenEXR (see D7842), devel/aros-sdk, devel/abi-compliance-checker, dns/dnsmasq, dns/dnsmasq-devel. The two dnsmask uses can be addressed with a change equivalent to D7842; the other two ports need more investigation. Comment Actions I really like this tool but you're right, we can just use the package. It will break the ports security-check thing which runs at 'make install' time. See OBJDUMP usage in /usr/ports/Mk/bsd.port.mk in security-check target and uses Mk/Scripts/security-check.awk for parsing. It looks like it is pretty trivial to convert to readelf format. Comment Actions For the ports infrastructure security-check thing we should just switch to readelf instead. A ports exp-run w/o objdump is in PR 212319. Failures were a bunch of gcc packages:
and x11-fm/gnome-commander2 Comment Actions Objdump removal tracking pr in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229046 |