graphics/OpenEXR: use readelf instead of objdump in library check
ClosedPublic
Actions

Authored by mandree on Sep 9 2016, 2:38 PM.

Details

Reviewers

emaste
bapt

Commits

rP421694: Fixup r421626 to unbreak build on newer readelf.
rP421626: Replace objdump by readelf. Fixes build on arm64.

Summary

The binutils-provided objdump in the base system will be removed soon (and is already not present on arm64). Switch the C++ library check to use readelf, which provides the same functionality.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 20225.Sep 9 2016, 2:38 PM

emaste retitled this revision from to graphics/OpenEXR: use readelf instead of objdump in library check.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added a reviewer: mandree.

emaste added a subscriber: andrew.

disconnecting objdump is discussed in D7338

emaste mentioned this in D7338: Disconnect objdump from the build.Sep 9 2016, 3:06 PM

bapt accepted this revision.Sep 9 2016, 3:26 PM

bapt added a reviewer: bapt.

This revision is now accepted and ready to land.Sep 9 2016, 3:26 PM

Will commit later, currently seeing make DEVELOPER=yes complaints about missing LIB_DEPENDS=.../libc++ on bare metal, though this may be an artifact of libc++ being installed from port as well as in base. Currently investigating.

The libc++ stuff is a red herring. pkg delete -y libc++ fixed that one for 10.3. Now testing other releases.

Closed by commit rP421626: Replace objdump by readelf. Fixes build on arm64. (authored by mandree). · Explain WhySep 9 2016, 6:50 PM

This revision was automatically updated to reflect the committed changes.

mandree mentioned this in rP421626: Replace objdump by readelf. Fixes build on arm64..

committed as SVN r421626