Page MenuHomeFreeBSD

graphics/OpenEXR: use readelf instead of objdump in library check
ClosedPublic

Authored by mandree on Sep 9 2016, 2:38 PM.

Details

Summary

The binutils-provided objdump in the base system will be removed soon (and is already not present on arm64). Switch the C++ library check to use readelf, which provides the same functionality.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emaste updated this revision to Diff 20225.Sep 9 2016, 2:38 PM
emaste retitled this revision from to graphics/OpenEXR: use readelf instead of objdump in library check.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added a reviewer: mandree.
emaste added a subscriber: andrew.
emaste added a comment.Sep 9 2016, 2:50 PM

disconnecting objdump is discussed in D7338

bapt accepted this revision.Sep 9 2016, 3:26 PM
bapt added a reviewer: bapt.
This revision is now accepted and ready to land.Sep 9 2016, 3:26 PM
mandree commandeered this revision.Sep 9 2016, 6:12 PM
mandree edited reviewers, added: emaste; removed: mandree.

Will commit later, currently seeing make DEVELOPER=yes complaints about missing LIB_DEPENDS=.../libc++ on bare metal, though this may be an artifact of libc++ being installed from port as well as in base. Currently investigating.

The libc++ stuff is a red herring. pkg delete -y libc++ fixed that one for 10.3. Now testing other releases.

This revision was automatically updated to reflect the committed changes.

committed as SVN r421626

emaste edited edge metadata.Sep 9 2016, 7:00 PM

committed as SVN r421626

Thanks!

mandree reopened this revision.Sep 10 2016, 1:59 PM

Antoine@ reported this broken on FreeBSD 11, which I can confirm. The readelf output format is changed... oh joy.

This revision is now accepted and ready to land.Sep 10 2016, 1:59 PM
mandree planned changes to this revision.Sep 10 2016, 2:00 PM
This revision was automatically updated to reflect the committed changes.

Oops, thanks for the fix.