Page MenuHomeFreeBSD

graphics/OpenEXR: use readelf instead of objdump in library check
ClosedPublic

Authored by mandree on Sep 9 2016, 2:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 8, 9:45 PM
Unknown Object (File)
Jan 17 2024, 6:21 PM
Unknown Object (File)
Jan 17 2024, 8:38 AM
Unknown Object (File)
Dec 22 2023, 11:11 PM
Unknown Object (File)
Dec 7 2023, 8:18 AM
Unknown Object (File)
Nov 13 2023, 10:15 AM
Unknown Object (File)
Nov 6 2023, 11:32 PM
Unknown Object (File)
Nov 6 2023, 11:19 PM
Subscribers

Details

Summary

The binutils-provided objdump in the base system will be removed soon (and is already not present on arm64). Switch the C++ library check to use readelf, which provides the same functionality.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste retitled this revision from to graphics/OpenEXR: use readelf instead of objdump in library check.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added a reviewer: mandree.
emaste added a subscriber: andrew.

disconnecting objdump is discussed in D7338

bapt added a reviewer: bapt.
This revision is now accepted and ready to land.Sep 9 2016, 3:26 PM
mandree edited reviewers, added: emaste; removed: mandree.

Will commit later, currently seeing make DEVELOPER=yes complaints about missing LIB_DEPENDS=.../libc++ on bare metal, though this may be an artifact of libc++ being installed from port as well as in base. Currently investigating.

The libc++ stuff is a red herring. pkg delete -y libc++ fixed that one for 10.3. Now testing other releases.

This revision was automatically updated to reflect the committed changes.

committed as SVN r421626

Thanks!

Antoine@ reported this broken on FreeBSD 11, which I can confirm. The readelf output format is changed... oh joy.

This revision is now accepted and ready to land.Sep 10 2016, 1:59 PM
This revision was automatically updated to reflect the committed changes.