Page MenuHomeFreeBSD
Differential D59180

arm64: Fix the capitalization of CurrentEL
ClosedPublic
Actions

Authored by andrew on Aug 25 2026, 2:37 PM.
Tags
None
Referenced Files
F174999636: D59180.diff
Wed, Oct 7, 1:09 PM
Unknown Object (File)
Tue, Oct 6, 8:30 AM
Unknown Object (File)
Sat, Oct 3, 10:46 PM
Unknown Object (File)
Sat, Oct 3, 9:01 PM
Unknown Object (File)
Fri, Oct 2, 11:12 PM
Unknown Object (File)
Fri, Oct 2, 4:04 AM
Unknown Object (File)
Fri, Oct 2, 1:14 AM
Unknown Object (File)
Thu, Oct 1, 4:05 PM
View All 60 Files
Subscribers
emaste
imp
kajetan.puchalski_arm.com

Details

Reviewers
manu
kajetan.puchalski_arm.com
Group Reviewers
arm64
Commits
rGdeb43dafdcd2: arm64: Fix the capitalization of CurrentEL
Summary

Use the same capitalization as the Arm documentation.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew created this revision.Aug 25 2026, 2:37 PM
Herald added a reviewer: manu. · View Herald TranscriptAug 25 2026, 2:37 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
andrew requested review of this revision.Aug 25 2026, 2:37 PM
Harbormaster completed remote builds in B76153: Diff 185034.Aug 25 2026, 2:37 PM
andrew added a parent revision: D59179: arm64: Add ICC_SGI1R_IRM_VAL and use it.Aug 25 2026, 2:37 PM
andrew added a child revision: D59181: arm64: Move the CNTV_CTL_EL0 fields to armreg.h.
kajetan.puchalski_arm.com accepted this revision.Tue, Sep 8, 2:58 PM
kajetan.puchalski_arm.com added a subscriber: kajetan.puchalski_arm.com.

There is one lowercase 'currentel' in the machdep file, though in a block of all-lowercase registers so maybe we don't want to capitalise that one. LGTM otherwise.

sys/arm64/arm64/machdep.c
1000:	PRINT_REG(currentel);
This revision is now accepted and ready to land.Tue, Sep 8, 2:58 PM
andrew added a comment.Wed, Sep 9, 2:20 PM

That code probably needs to be updated, e.g. it's missing some ID registers

Closed by commit rGdeb43dafdcd2: arm64: Fix the capitalization of CurrentEL (authored by andrew). · Explain WhyWed, Sep 9, 2:23 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rGdeb43dafdcd2: arm64: Fix the capitalization of CurrentEL.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
4 lines
6 lines
include/
12 lines

Diff 186266

View Options

sys/arm64/arm64/locore.S

Loading...
View Options

sys/arm64/arm64/machdep.c

Loading...
View Options

sys/arm64/include/armreg.h

Loading...