Page MenuHomeFreeBSD
Differential D59427

ipfw: cleanup !FreeBSD and !_KERNEL code
AcceptedPublic
Actions

Authored by glebius on Fri, Sep 4, 9:57 PM.
Tags
None
Referenced Files
F170930475: D59427.diff
Mon, Sep 7, 4:35 PM
Unknown Object (File)
Sun, Sep 6, 2:54 PM
Unknown Object (File)
Sun, Sep 6, 3:32 AM
Unknown Object (File)
Sat, Sep 5, 9:35 PM
Unknown Object (File)
Sat, Sep 5, 8:08 AM
Unknown Object (File)
Sat, Sep 5, 12:03 AM
Unknown Object (File)
Fri, Sep 4, 11:58 PM
Subscribers
donner
imp
melifaro
vegeta_tuxpowered.net

Details

Reviewers
ae
lytboris_gmail.com
Group Reviewers
network
Summary

These are leftovers from last import from Luigi Rizzo in 2013, that were
never compiled checked since and lots of changes have had happened since
and more changes to come. Let's not pretend ipfw is buildable on
something else than FreeBSD nor it can be compiled for userland.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76593
Build 73476: arc lint + arc unit

Event Timeline

glebius created this revision.Fri, Sep 4, 9:57 PM
Herald added subscribers: vegeta_tuxpowered.net, donner, melifaro, imp. · View Herald TranscriptFri, Sep 4, 9:57 PM
glebius requested review of this revision.Fri, Sep 4, 9:57 PM
Harbormaster completed remote builds in B76539: Diff 185873.Fri, Sep 4, 9:57 PM
lytboris_gmail.com added a comment.Sun, Sep 6, 2:11 PM

There are two USERSPACE ifdefs in dummynet code as well:

ip_dn_io.c:#ifdef USERSPACE
ip_dn_private.h:#ifdef USERSPACE

Should we remove them as well?

glebius updated this revision to Diff 186008.Sun, Sep 6, 4:37 PM
  • Cover dummynet, too.
Harbormaster completed remote builds in B76593: Diff 186008.Sun, Sep 6, 4:37 PM
lytboris_gmail.com accepted this revision.Sun, Sep 6, 5:10 PM

LGTM

This revision is now accepted and ready to land.Sun, Sep 6, 5:10 PM

Revision Contents
Changeset List

PathSize
sys/
netpfil/
ipfw/
20 lines
28 lines
28 lines
39 lines
5 lines

Diff 186008

View Options

sys/netpfil/ipfw/dn_sched_qfq.c

Loading...
View Options

sys/netpfil/ipfw/ip_dn_io.c

Loading...
View Options

sys/netpfil/ipfw/ip_dn_private.h

Loading...
View Options

sys/netpfil/ipfw/ip_fw2.c

Loading...
View Options

sys/netpfil/ipfw/ip_fw_log.c

Loading...