ipfw: cleanup !FreeBSD and !_KERNEL code
ClosedPublic
Actions

Authored by glebius on Fri, Sep 4, 9:57 PM.

Details

Reviewers

ae
lytboris_gmail.com

Group Reviewers

network

Commits

rG58031cbd54b8: ipfw: cleanup !FreeBSD and !_KERNEL code

Summary

These are leftovers from last import from Luigi Rizzo in 2013, that were
never compiled checked since and lots of changes have had happened since
and more changes to come. Let's not pretend ipfw is buildable on
something else than FreeBSD nor it can be compiled for userland.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76539
Build 73422: arc lint + arc unit

Event Timeline

glebius created this revision.Fri, Sep 4, 9:57 PM

Herald added subscribers: vegeta_tuxpowered.net, donner, melifaro, imp. · View Herald TranscriptFri, Sep 4, 9:57 PM

glebius requested review of this revision.Fri, Sep 4, 9:57 PM

Harbormaster completed remote builds in B76539: Diff 185873.Fri, Sep 4, 9:57 PM

There are two USERSPACE ifdefs in dummynet code as well:

ip_dn_io.c:#ifdef USERSPACE
ip_dn_private.h:#ifdef USERSPACE

Should we remove them as well?

Cover dummynet, too.

Harbormaster completed remote builds in B76593: Diff 186008.Sun, Sep 6, 4:37 PM

LGTM

This revision is now accepted and ready to land.Sun, Sep 6, 5:10 PM

Closed by commit rG58031cbd54b8: ipfw: cleanup !FreeBSD and !_KERNEL code (authored by glebius). · Explain WhyFri, Sep 18, 10:51 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG58031cbd54b8: ipfw: cleanup !FreeBSD and !_KERNEL code.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

ipfw/

ip_fw2.c

39 lines

ip_fw_log.c

5 lines

Diff 185873

View Options

sys/netpfil/ipfw/ip_fw2.c