Page MenuHomeFreeBSD
Differential D59411

tty_pts: reduce/correct libatf-c linkage
ClosedPublic
Actions

Authored by ngie on Fri, Sep 4, 6:18 PM.
Tags
None
Referenced Files
F171063963: D59411.id.diff
Tue, Sep 8, 11:58 AM
F170955349: D59411.id185850.diff
Mon, Sep 7, 8:32 PM
F170950666: D59411.id185849.diff
Mon, Sep 7, 7:45 PM
F170917193: D59411.id.diff
Mon, Sep 7, 1:58 PM
Unknown Object (File)
Mon, Sep 7, 11:14 AM
Unknown Object (File)
Mon, Sep 7, 6:42 AM
Unknown Object (File)
Mon, Sep 7, 4:48 AM
Unknown Object (File)
Mon, Sep 7, 4:48 AM
View All 12 Files
Subscribers
imp
tests

Details

Reviewers
bdrewery
kevans
Commits
rG5b10c3c3e3d5: tty_pts: reduce/correct libatf-c linkage
Summary

ATF_TESTS_C automatically adds the appropriate library to LDADD --
there's no need to manually append the same library.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76520
Build 73403: arc lint + arc unit

Event Timeline

ngie created this revision.Fri, Sep 4, 6:18 PM
Herald added a subscriber: imp. · View Herald TranscriptFri, Sep 4, 6:18 PM
ngie requested review of this revision.Fri, Sep 4, 6:18 PM
Harbormaster completed remote builds in B76520: Diff 185849.Fri, Sep 4, 6:18 PM
ngie added reviewers: bdrewery, kevans.Fri, Sep 4, 6:19 PM
ngie added a subscriber: tests.
kevans accepted this revision.Fri, Sep 4, 6:27 PM

No idea why I would have done this, I've done plenty of atf-c... thanks!

This revision is now accepted and ready to land.Fri, Sep 4, 6:27 PM
Closed by commit rG5b10c3c3e3d5: tty_pts: reduce/correct libatf-c linkage (authored by ngie). · Explain WhyFri, Sep 4, 6:33 PM
This revision was automatically updated to reflect the committed changes.
ngie added a commit: rG5b10c3c3e3d5: tty_pts: reduce/correct libatf-c linkage.
ngie added a comment.Fri, Sep 4, 6:38 PM
In D59411#1362818, @kevans wrote:

No idea why I would have done this, I've done plenty of atf-c... thanks!

It happens :) -- thanks for the quick review!

Revision Contents
Changeset List

PathSize
tests/
sys/
kern/
3 lines

Diff 185849

View Options

tests/sys/kern/Makefile

Loading...