tty_pts: reduce/correct libatf-c linkage
ClosedPublic
Actions

Authored by ngie on Sep 4 2026, 6:18 PM.

Details

Reviewers

bdrewery
kevans

Commits

rG5936c0a36b4d: tty_pts: reduce/correct libatf-c linkage
rG343618cfe7af: tty_pts: reduce/correct libatf-c linkage
rG5b10c3c3e3d5: tty_pts: reduce/correct libatf-c linkage

Summary

ATF_TESTS_C automatically adds the appropriate library to LDADD --
there's no need to manually append the same library.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ngie created this revision.Sep 4 2026, 6:18 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 4 2026, 6:18 PM

ngie requested review of this revision.Sep 4 2026, 6:18 PM

Harbormaster completed remote builds in B76520: Diff 185849.Sep 4 2026, 6:18 PM

ngie added reviewers: bdrewery, kevans.Sep 4 2026, 6:19 PM

ngie added a subscriber: tests.

No idea why I would have done this, I've done plenty of atf-c... thanks!

This revision is now accepted and ready to land.Sep 4 2026, 6:27 PM

Closed by commit rG5b10c3c3e3d5: tty_pts: reduce/correct libatf-c linkage (authored by ngie). · Explain WhySep 4 2026, 6:33 PM

This revision was automatically updated to reflect the committed changes.

ngie added a commit: rG5b10c3c3e3d5: tty_pts: reduce/correct libatf-c linkage.

In D59411#1362818, @kevans wrote:

No idea why I would have done this, I've done plenty of atf-c... thanks!

It happens :) -- thanks for the quick review!

ngie added a commit: rG343618cfe7af: tty_pts: reduce/correct libatf-c linkage.Tue, Sep 22, 6:50 AM

ngie added a commit: rG5936c0a36b4d: tty_pts: reduce/correct libatf-c linkage.Tue, Sep 22, 6:54 AM

Revision Contents
Changeset List

Path

Size

tests/

sys/

kern/

Makefile

3 lines

Diff 185850

View Options

tty_pts: reduce/correct libatf-c linkageClosedPublicActions