libc: Add WCHAR_WIDTH in <wchar.h> as well
ClosedPublic
Actions

Authored by kfv on Fri, Sep 4, 9:59 AM.

Details

Reviewers

dteske
fuz
andrew
manu

Commits

rG72ed6f9c9dc9: libc: Add WCHAR_WIDTH in <wchar.h> as well

Summary

Define __WCHAR_WIDTH in sys/_types.h and derive WCHAR_WIDTH from
that, the same way as WCHAR_MIN and WCHAR_MAX, in both <wchar.h>
and <stdint.h> as per C23 §7.31.1 and §7.22.3.4, respectively.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76491
Build 73374: arc lint + arc unit

Event Timeline

kfv created this revision.Fri, Sep 4, 9:59 AM

Herald added a reviewer: andrew. · View Herald TranscriptFri, Sep 4, 9:59 AM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: riscv, jhibbits, emaste, imp. · View Herald Transcript

kfv requested review of this revision.Fri, Sep 4, 9:59 AM

Harbormaster completed remote builds in B76488: Diff 185808.Fri, Sep 4, 9:59 AM

If the size is the same on all platforms, it should not be in the platform-specific _types.h files.

If the size is the same on all platforms, it should not be in the platform-specific _types.h files.

I was considering putting it in sys/sys/_types.h, but wasn't sure since the size could differ on other architectures (applies not to any we support, though). I'll take care of it.

Move __WCHAR_WIDTH into sys/sys/_types.h

Harbormaster completed remote builds in B76491: Diff 185815.Fri, Sep 4, 1:01 PM

Well it was previously a platform-independent definition in _stdint.h, so I don't see how it would become platform-dependent in the future. That said, it can always be changed if needed.

Looks good to me.
Approved for commit.

This revision is now accepted and ready to land.Fri, Sep 4, 2:13 PM

kfv edited the summary of this revision. (Show Details)Sat, Sep 5, 10:44 AM

Closed by commit rG72ed6f9c9dc9: libc: Add WCHAR_WIDTH in <wchar.h> as well (authored by kfv). · Explain WhySat, Sep 5, 10:49 AM

This revision was automatically updated to reflect the committed changes.

kfv added a commit: rG72ed6f9c9dc9: libc: Add WCHAR_WIDTH in <wchar.h> as well.