arm64: Update GICv3/4 register macros
Needs ReviewPublic
Actions

Authored by andrew on Tue, Aug 25, 2:38 PM.

Details

Reviewers

manu

Group Reviewers

arm64

Summary

Use the field names found in the documentation and drop _EL1 where
appropriate. This will reduce the diff when these are generated from
the BSD licensed JSON register files.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76155
Build 73038: arc lint + arc unit

Event Timeline

andrew created this revision.Tue, Aug 25, 2:38 PM

Herald added a reviewer: manu. · View Herald TranscriptTue, Aug 25, 2:38 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Tue, Aug 25, 2:38 PM

andrew added a parent revision: D59181: arm64: Move the CNTV_CTL_EL0 fields to armreg.h.

Harbormaster completed remote builds in B76155: Diff 185036.Tue, Aug 25, 2:38 PM

kajetan.puchalski_arm.com added a subscriber: kajetan.puchalski_arm.com.Tue, Sep 8, 3:15 PM

kajetan.puchalski_arm.com added inline comments.

sys/arm64/include/armreg.h
819	Are we sure about dropping _EL1_ from here? `EOIMode` as a field only exists in ICC_CTLR_EL1 as far as I can tell.
822	Similarly, we only have ICC_IAR0_EL1 and ICC_IAR1_EL1. If the special INTID 1023 is shared between Group 0 and Group 1 interrupts, would this not be more aptly named something like `ICC_IAR_EL1_SPUR`?
824–828	Both of these registers only have an EL1 variant so same as above
859–860	This field exists in _EL1, _EL2 and _EL3 so the change makes sense, but maybe it'd be good to update the comment as well?