Page MenuHomeFreeBSD
Differential D59154

nvme: limit I/O queue trackers to Identify MAXCMD
AcceptedPublic
Actions

Authored by seuros on Mon, Aug 24, 6:20 PM.
Tags
None
Referenced Files
F169853676: D59154.diff
Wed, Sep 2, 6:45 PM
F169791371: D59154.diff
Wed, Sep 2, 2:11 PM
F169769345: D59154.diff
Wed, Sep 2, 12:33 PM
F169769102: D59154.id184922.diff
Wed, Sep 2, 12:31 PM
F169738098: D59154.id184990.diff
Wed, Sep 2, 10:28 AM
F169684682: D59154.id184922.diff
Wed, Sep 2, 7:11 AM
Unknown Object (File)
Wed, Sep 2, 1:02 AM
Unknown Object (File)
Tue, Sep 1, 9:04 PM
View All 36 Files
Subscribers
dab
imp
ngie

Details

Reviewers
adrian
dteske
imp
ngie
Summary

MAXCMD is the maximum number of commands the controller processes at
one time for a particular I/O queue. Allocating more trackers than
that only queues commands inside the controller. Controllers
reporting 0 are unaffected.

Approved by: ngie (co-mentor)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 76113
Build 72996: arc lint + arc unit

Event Timeline

seuros created this revision.Mon, Aug 24, 6:20 PM
Herald added subscribers: dab, imp. · View Herald TranscriptMon, Aug 24, 6:20 PM
seuros requested review of this revision.Mon, Aug 24, 6:20 PM
Harbormaster completed remote builds in B76059: Diff 184922.Mon, Aug 24, 6:20 PM
seuros added reviewers: adrian, dteske, imp.Mon, Aug 24, 6:22 PM
seuros added a child revision: D59155: nvme: program the arbitration burst from Identify RAB.
seuros added a parent revision: D59153: nvme: name the Create I/O queue cdw11 fields, use Medium QPRIO.
seuros updated this revision to Diff 184990.Tue, Aug 25, 6:35 AM

rebase

Harbormaster completed remote builds in B76113: Diff 184990.Tue, Aug 25, 6:35 AM
imp accepted this revision.Tue, Aug 25, 6:57 PM
imp added inline comments.
sys/dev/nvme/nvme_ctrlr.c
200

This printf should be behind bootverbose, I think.

This revision is now accepted and ready to land.Tue, Aug 25, 6:57 PM
seuros added inline comments.Tue, Aug 25, 8:05 PM
sys/dev/nvme/nvme_ctrlr.c
200

I tested it with around 30 models, but not all.

I want to keep it like this for few weeks so we can identify the disks that are quirky.

After that we can remove it or guard it.

imp added inline comments.Tue, Sep 1, 7:45 PM
sys/dev/nvme/nvme_ctrlr.c
200

OK.

ngie accepted this revision.Wed, Sep 2, 2:43 AM
ngie added a subscriber: ngie.

Approved by: ngie (co-mentor)

seuros edited the summary of this revision. (Show Details)Wed, Sep 2, 8:33 AM
seuros marked 2 inline comments as done.

Revision Contents
Changeset List

PathSize
sys/
dev/
nvme/
7 lines

Diff 184990

View Options

sys/dev/nvme/nvme_ctrlr.c

Loading...