Page MenuHomeFreeBSD
Differential D59154

nvme: limit I/O queue trackers to Identify MAXCMD
ClosedPublic
Actions

Authored by seuros on Aug 24 2026, 6:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 24, 5:46 AM
Unknown Object (File)
Tue, Sep 22, 7:04 PM
Unknown Object (File)
Sat, Sep 19, 3:23 PM
Unknown Object (File)
Sat, Sep 19, 1:31 PM
Unknown Object (File)
Thu, Sep 17, 6:59 AM
Unknown Object (File)
Tue, Sep 15, 5:52 AM
Unknown Object (File)
Tue, Sep 15, 2:56 AM
Unknown Object (File)
Mon, Sep 14, 1:07 PM
View All 83 Files
Subscribers
dab
imp
ngie

Details

Reviewers
adrian
dteske
imp
ngie
Commits
rGf195b9f3f6f7: nvme: limit I/O queue trackers to Identify MAXCMD
Summary

MAXCMD is the maximum number of commands the controller processes at
one time for a particular I/O queue. Allocating more trackers than
that only queues commands inside the controller. Controllers
reporting 0 are unaffected.

Approved by: ngie (co-mentor)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 76113
Build 72996: arc lint + arc unit

Event Timeline

seuros created this revision.Aug 24 2026, 6:20 PM
Herald added subscribers: dab, imp. · View Herald TranscriptAug 24 2026, 6:20 PM
seuros requested review of this revision.Aug 24 2026, 6:20 PM
Harbormaster completed remote builds in B76059: Diff 184922.Aug 24 2026, 6:20 PM
seuros added reviewers: adrian, dteske, imp.Aug 24 2026, 6:22 PM
seuros added a child revision: D59155: nvme: program the arbitration burst from Identify RAB.
seuros added a parent revision: D59153: nvme: name the Create I/O queue cdw11 fields, use Medium QPRIO.
seuros updated this revision to Diff 184990.Aug 25 2026, 6:35 AM

rebase

Harbormaster completed remote builds in B76113: Diff 184990.Aug 25 2026, 6:35 AM
imp accepted this revision.Aug 25 2026, 6:57 PM
imp added inline comments.
sys/dev/nvme/nvme_ctrlr.c
200

This printf should be behind bootverbose, I think.

This revision is now accepted and ready to land.Aug 25 2026, 6:57 PM
seuros added inline comments.Aug 25 2026, 8:05 PM
sys/dev/nvme/nvme_ctrlr.c
200

I tested it with around 30 models, but not all.

I want to keep it like this for few weeks so we can identify the disks that are quirky.

After that we can remove it or guard it.

imp added inline comments.Tue, Sep 1, 7:45 PM
sys/dev/nvme/nvme_ctrlr.c
200

OK.

ngie accepted this revision.Wed, Sep 2, 2:43 AM
ngie added a subscriber: ngie.

Approved by: ngie (co-mentor)

seuros edited the summary of this revision. (Show Details)Wed, Sep 2, 8:33 AM
seuros marked 2 inline comments as done.
Closed by commit rGf195b9f3f6f7: nvme: limit I/O queue trackers to Identify MAXCMD (authored by seuros). · Explain WhyTue, Sep 8, 12:21 AM
This revision was automatically updated to reflect the committed changes.
seuros added a commit: rGf195b9f3f6f7: nvme: limit I/O queue trackers to Identify MAXCMD.

Revision Contents
Changeset List

PathSize
sys/
dev/
nvme/
7 lines

Diff 184990

View Options

sys/dev/nvme/nvme_ctrlr.c

Loading...