nvme: drop the S3X single-outstanding-I/O quirk
AcceptedPublic
Actions

Authored by seuros on Mon, Aug 24, 6:20 PM.

Details

Reviewers

ngie
adrian
imp

Summary

The quirk's 8KB transfer clamp exposed raw character-device I/O to
the oversized-mapping stall fixed earlier, and its single tracker
turned a stranded request into a complete I/O stall. Without it an
S3X controller runs 128 trackers at its MDTS-derived transfer size
with no retries, failures, or timeouts, at about seven times the
serialized throughput.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 76115
Build 72998: arc lint + arc unit

Event Timeline

seuros created this revision.Mon, Aug 24, 6:20 PM

Herald added subscribers: dab, imp. · View Herald TranscriptMon, Aug 24, 6:20 PM

seuros requested review of this revision.Mon, Aug 24, 6:20 PM

Harbormaster completed remote builds in B76061: Diff 184924.Mon, Aug 24, 6:20 PM

seuros added reviewers: ngie, adrian, imp.Mon, Aug 24, 6:23 PM

seuros added a parent revision: D59155: nvme: program the arbitration burst from Identify RAB.

rebase

Harbormaster completed remote builds in B76115: Diff 184992.Tue, Aug 25, 6:35 AM

imp accepted this revision.Tue, Aug 25, 6:55 PM

This revision is now accepted and ready to land.Tue, Aug 25, 6:55 PM

My MacBookPro13,1 boots with this patch set and feels much snappier than before (didn't measure it though). Great job!

@seuros: please add:

Approved by: ngie (co-mentor)

to your commit message and add an appropriate MFC after: time. A change like this should probably get "3 days", "1 week", etc -- higher seems a bit unnecessary :).

Let @adrian or I know if you need help staging this change using git arc!