nvme: limit I/O queue trackers to Identify MAXCMD
ClosedPublic
Actions

Authored by seuros on Aug 24 2026, 6:20 PM.

Details

Reviewers

adrian
dteske
imp
ngie

Commits

rGf195b9f3f6f7: nvme: limit I/O queue trackers to Identify MAXCMD

Summary

MAXCMD is the maximum number of commands the controller processes at
one time for a particular I/O queue. Allocating more trackers than
that only queues commands inside the controller. Controllers
reporting 0 are unaffected.

Approved by: ngie (co-mentor)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

seuros created this revision.Aug 24 2026, 6:20 PM

Herald added subscribers: dab, imp. · View Herald TranscriptAug 24 2026, 6:20 PM

seuros requested review of this revision.Aug 24 2026, 6:20 PM

Harbormaster completed remote builds in B76059: Diff 184922.Aug 24 2026, 6:20 PM

seuros added reviewers: adrian, dteske, imp.Aug 24 2026, 6:22 PM

seuros added a child revision: D59155: nvme: program the arbitration burst from Identify RAB.

seuros added a parent revision: D59153: nvme: name the Create I/O queue cdw11 fields, use Medium QPRIO.

rebase

Harbormaster completed remote builds in B76113: Diff 184990.Aug 25 2026, 6:35 AM

imp accepted this revision.Aug 25 2026, 6:57 PM

imp added inline comments.

sys/dev/nvme/nvme_ctrlr.c
200	This printf should be behind bootverbose, I think.

This revision is now accepted and ready to land.Aug 25 2026, 6:57 PM

seuros added inline comments.Aug 25 2026, 8:05 PM

sys/dev/nvme/nvme_ctrlr.c
200	I tested it with around 30 models, but not all. I want to keep it like this for few weeks so we can identify the disks that are quirky. After that we can remove it or guard it.