tests: exercise unix `connectat(2)` with a socket peer descriptor
ClosedPublic
Actions

Authored by inquire_JohnEricson.me on Wed, Jul 22, 9:37 PM.

Details

Reviewers

markj
kib

Group Reviewers

capsicum

Commits

rGe181e2342d11: tests: exercise unix connectat(2) with a socket peer descriptor

Summary

Cover the new fd-direct connect path: stream connect and data passing,
the peer address reported by getpeername(2), datagram to an unbound
peer, the EINVAL/ENOTSOCK/EPROTOTYPE/ECONNREFUSED error matrix,
and the Capsicum token semantics — a descriptor limited to
CAP_CONNECTAT can be connected to but not listened on, accepted from,
or read, and one lacking CAP_CONNECTAT cannot be a connect target.

Stream listeners are always bound: uipc_listen() refuses unbound
sockets with EDESTADDRREQ, so an unbound fd-direct listener is not
reachable even with this feature.

Signed-off-by: John Ericson <John.Ericson@Obsidian.Systems>
Assisted-by: Claude Code (Claude Opus 4.8 and Fable 5)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 75401
Build 72284: arc lint + arc unit

Event Timeline

inquire_JohnEricson.me created this revision.Wed, Jul 22, 9:37 PM

Herald added subscribers: jonathan, imp. · View Herald TranscriptWed, Jul 22, 9:37 PM

inquire_JohnEricson.me requested review of this revision.Wed, Jul 22, 9:37 PM

Harbormaster completed remote builds in B75029: Diff 182484.Wed, Jul 22, 9:37 PM

inquire_JohnEricson.me added a parent revision: D58405: unix: allow `connectat(2)` to name the peer socket by descriptor.Wed, Jul 22, 9:38 PM

inquire_JohnEricson.me added a reviewer: capsicum.Thu, Jul 23, 4:45 AM

inquire_JohnEricson.me added reviewers: markj, kib.

inquire_JohnEricson.me added a parent revision: D58462: unix: factor `unp_connectat_peer()` out of `unp_connectat()`.Sat, Jul 25, 8:28 PM

inquire_JohnEricson.me removed a parent revision: D58462: unix: factor `unp_connectat_peer()` out of `unp_connectat()`.Sat, Jul 25, 8:31 PM

inquire_JohnEricson.me edited the summary of this revision. (Show Details)Sun, Jul 26, 11:11 PM

These tests don't exercise fdescfs lookups, nor handling of O_PATH sockets. Were you planning to add something for that? It should be fairly easy to create fdescfs mounts from within the tests themselves, tests/sys/kern/jail_lookup_root.c has some examples of this.

tests/sys/kern/unix_connectat.c
98	Not hugely important, but I think it's good form to check for errors from close(), doing so can catch test bugs (and, rarely, kernel bugs).

These tests don't exercise fdescfs lookups, nor handling of O_PATH sockets. Were you planning to add something for that?

There is some leniency in here so that the tests pass with or without fdescfs, but I didn't know it was OK to mount it within the tests. I'll go do that instead; that's definitely better! And I'll make sure we get O_PATH tested too.

It should be fairly easy to create fdescfs mounts from within the tests themselves, tests/sys/kern/jail_lookup_root.c has some examples of this.

Thanks, that will be useful to make sure I get the idiom correct.