Differential D58628

e1000: defer sysctl-driven reinit to the admin task
ClosedPublic
Actions

Authored by guest-seuros on Mon, Aug 3, 11:27 PM.

Tags

Referenced Files

	Unknown Object (File)
	Fri, Aug 21, 8:48 PM

	Unknown Object (File)
	Fri, Aug 21, 11:37 AM

	Unknown Object (File)
	Fri, Aug 21, 6:33 AM

	Unknown Object (File)
	Wed, Aug 19, 11:01 AM

	Unknown Object (File)
	Wed, Aug 19, 5:20 AM

	Unknown Object (File)
	Tue, Aug 18, 4:56 PM

	Unknown Object (File)
	Sun, Aug 16, 12:47 PM

	Unknown Object (File)
	Sun, Aug 16, 12:52 AM

View All 32 Files

Subscribers

Details

Reviewers

imp
adrian
kbowling

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rG0fa6b2c523ee: e1000: defer sysctl-driven reinit to the admin task
rGcbedee9bdcda: e1000: defer sysctl-driven reinit to the admin task
rGabdde8b60281: e1000: defer sysctl-driven reinit to the admin task

Summary

panic: Lock iflib ctx lock not exclusively locked @

/usr/src/sys/dev/e1000/e1000_ich8lan.c:1906

The assertion is compiled out without INVARIANTS, where the same write
instead resets the MAC and takes the ICH software flag while the queues
stay live and an ioctl or the admin task may be running.

Requesting the reset through iflib and let the admin task perform the
stop/init under the context lock, matching what the VF and SR-IOV paths
already do.

MFC: 1 week

Test Plan

Reproduced the panic on an Intel I218-V (ich8lan) by writing
dev.em.0.eee_control; with the change the same write completes and the
interface reinitializes cleanly.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 75353
Build 72236: arc lint + arc unit

Event Timeline

guest-seuros created this revision.Mon, Aug 3, 11:27 PM

Owners added a reviewer: Restricted Owners Package.Mon, Aug 3, 11:27 PM

guest-seuros requested review of this revision.Mon, Aug 3, 11:27 PM

Harbormaster completed remote builds in B75353: Diff 183346.Mon, Aug 3, 11:27 PM

adrian added projects: network, Intel Networking, iflib.Mon, Aug 3, 11:28 PM

guest-seuros mentioned this in D58629: igc: defer sysctl-driven reinit to the admin task.Mon, Aug 3, 11:32 PM

guest-seuros added a child revision: D58629: igc: defer sysctl-driven reinit to the admin task.Mon, Aug 3, 11:33 PM

adrian added a reviewer: kbowling.Mon, Aug 3, 11:36 PM

Can you do the same for media_change and if_resume?

This revision now requires changes to proceed.Tue, Aug 4, 9:05 PM

This revision was not accepted when it landed; it landed in state Needs Revision.Wed, Aug 5, 4:43 AM

Closed by commit rGabdde8b60281: e1000: defer sysctl-driven reinit to the admin task (authored by guest-seuros, committed by Kevin Bowling <kbowling@FreeBSD.org>). · Explain Why

This revision was automatically updated to reflect the committed changes.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGabdde8b60281: e1000: defer sysctl-driven reinit to the admin task.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGcbedee9bdcda: e1000: defer sysctl-driven reinit to the admin task.Wed, Aug 12, 8:30 PM

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG0fa6b2c523ee: e1000: defer sysctl-driven reinit to the admin task.

Revision Contents
Changeset List

Path

Size

sys/

dev/

e1000/

14 lines

Diff 183346

sys/dev/e1000/if_em.c

Loading...