Page MenuHomeFreeBSD
Differential D58593

Bump __FreeBSD_version to 1600020 after the amd64 FRED KBI change
AbandonedPublic
Actions

Authored by chris.longros_gmail.com on Aug 2 2026, 3:04 PM.
Tags
None
Referenced Files
F173518761: D58593.diff
Sat, Sep 26, 1:19 PM
F173495553: D58593.diff
Sat, Sep 26, 8:57 AM
Unknown Object (File)
Thu, Sep 24, 8:12 AM
Unknown Object (File)
Thu, Sep 24, 6:37 AM
Unknown Object (File)
Sat, Sep 19, 11:14 PM
Unknown Object (File)
Sat, Sep 19, 4:59 PM
Unknown Object (File)
Sat, Sep 19, 4:59 PM
Unknown Object (File)
Sat, Sep 19, 12:24 AM
View All 46 Files
Subscribers
None

Details

Reviewers
kib
emaste
Summary

6e93f5e4d693 ("amd64: FRED support") changed the kernel KBI without bumping __FreeBSD_version. On amd64 CURRENT, kldload amdgpu panics with the drm-latest-kmod package.

Test Plan

Testing performed:
amd64 16.0-CURRENT GENERIC. Pre-FRED drm-latest-kmod panics on kldload; rebuilt against post-FRED /usr/src it initializes amdgpu.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 75338
Build 72221: arc lint + arc unit

Event Timeline

chris.longros_gmail.com created this revision.Aug 2 2026, 3:04 PM
chris.longros_gmail.com held this revision as a draft.
Herald added a subscriber: imp. · View Herald TranscriptAug 2 2026, 3:04 PM
Harbormaster completed remote builds in B75338: Diff 183233.Aug 2 2026, 3:04 PM
chris.longros_gmail.com removed subscribers: imp, x11.Aug 2 2026, 3:04 PM
chris.longros_gmail.com published this revision for review.Aug 2 2026, 3:05 PM
chris.longros_gmail.com edited the summary of this revision. (Show Details)
chris.longros_gmail.com edited the test plan for this revision. (Show Details)
kib added a comment.Aug 2 2026, 3:30 PM

What are the hypothetical KBI incompatibilities caused by the FRED commit?

chris.longros_gmail.com added a comment.Aug 8 2026, 2:40 PM
In D58593#1344656, @kib wrote:

What are the hypothetical KBI incompatibilities caused by the FRED commit?

struct pcb gained six fields and grew 16 bytes so td_lkpi_task moved offset. Built modules before and after the commit read different offsets.

kib accepted this revision.Aug 8 2026, 3:58 PM

Ok. I think we also need to check the lkpi pointer in the kern_thread.c asserts.

This revision is now accepted and ready to land.Aug 8 2026, 3:58 PM
chris.longros_gmail.com mentioned this in D58743: Bump __FreeBSD_version to 1501502.Aug 9 2026, 10:46 AM
chris.longros_gmail.com added a comment.Aug 13 2026, 5:36 PM

I think this revision is not anymore relevant as the video(4) driver bumped the version to 1600020.

emaste added a comment.Aug 13 2026, 5:50 PM

Yeah, you can abandon it for it to close. I'll add it to the porter's handbook.

chris.longros_gmail.com abandoned this revision.Aug 13 2026, 6:08 PM

Revision Contents
Changeset List

PathSize
sys/
sys/
2 lines

Diff 183233

View Options

sys/sys/param.h

Loading...