ptrace: Propagate errors from set_fpregs()
ClosedPublic
Actions

Authored by markj on Jul 31 2026, 3:30 PM.

Details

Reviewers

kib

Commits

rG1932bd20ed53: ptrace: Propagate errors from set_fpregs()

Summary

Otherwise ptrace(PT_SETREGSET) will not return errors to userspace.

Fixes: cef05c5a62ba ("amd64: do not allow to set reserved bits in MXCSR for ptrace(PT_SETFPREGS)")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75321
Build 72204: arc lint + arc unit

Event Timeline

markj created this revision.Jul 31 2026, 3:30 PM

Herald added subscribers: olce, imp. · View Herald TranscriptJul 31 2026, 3:30 PM

markj requested review of this revision.Jul 31 2026, 3:30 PM

Harbormaster completed remote builds in B75320: Diff 183164.Jul 31 2026, 3:30 PM

kib accepted this revision.Jul 31 2026, 3:40 PM

kib added inline comments.

sys/kern/imgact_elf.c
2395	Or just `return (set_fpregsXX(...) == 0);`
2398–2399	Same there, then `return (true);` is not needed.

This revision is now accepted and ready to land.Jul 31 2026, 3:40 PM

Simplify

This revision now requires review to proceed.Jul 31 2026, 3:44 PM

Harbormaster completed remote builds in B75321: Diff 183166.Jul 31 2026, 3:44 PM

kib accepted this revision.Jul 31 2026, 3:47 PM

This revision is now accepted and ready to land.Jul 31 2026, 3:47 PM

Closed by commit rG1932bd20ed53: ptrace: Propagate errors from set_fpregs() (authored by markj). · Explain WhyJul 31 2026, 7:48 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG1932bd20ed53: ptrace: Propagate errors from set_fpregs().

Revision Contents
Changeset List

Path

Size

sys/

kern/

imgact_elf.c

8 lines

Diff 183166

View Options

ptrace: Propagate errors from set_fpregs()ClosedPublicActions