Page MenuHomeFreeBSD
Differential D57266

rtnetlink: Fix weight overflow in RTA_MULTIPATH
ClosedPublic
Actions

Authored by pouria on May 27 2026, 10:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 7, 1:11 PM
Unknown Object (File)
Sun, Sep 6, 10:38 AM
Unknown Object (File)
Sun, Sep 6, 9:21 AM
Unknown Object (File)
Sun, Sep 6, 4:30 AM
Unknown Object (File)
Sat, Sep 5, 8:13 AM
Unknown Object (File)
Sat, Sep 5, 1:20 AM
Unknown Object (File)
Fri, Sep 4, 4:02 AM
Unknown Object (File)
Fri, Sep 4, 2:36 AM
View All 74 Files
Subscribers
imp

Details

Reviewers
melifaro
glebius
markj
emaste
bz
Group Reviewers
network
Commits
rG97f7b21dd525: rtnetlink: Fix weight overflow in RTA_MULTIPATH
Summary

If the weight value is larger than 8 bits, set it to the maximum.
Also, only send RTA_WEIGHT if its value is not the default.
This reduces message size and matches the behavior of
non-multipath routes.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 73471
Build 70354: arc lint + arc unit

Event Timeline

pouria created this revision.May 27 2026, 10:03 AM
Herald added a subscriber: imp. · View Herald TranscriptMay 27 2026, 10:03 AM
pouria requested review of this revision.May 27 2026, 10:03 AM
Harbormaster completed remote builds in B73471: Diff 178713.May 27 2026, 10:03 AM
emaste added inline comments.May 27 2026, 2:09 PM
sys/netlink/route/rt.c
220

Use MAX()?

pouria updated this revision to Diff 178733.May 27 2026, 2:15 PM

Address @emaste comment.

Harbormaster completed remote builds in B73481: Diff 178733.May 27 2026, 2:16 PM
markj added inline comments.May 27 2026, 3:54 PM
sys/netlink/route/rt.c
246

Doesn't this break backwards compatibility? Or is this code new enough that it doesn't matter?

pouria marked an inline comment as done.May 27 2026, 8:51 PM
pouria added inline comments.
sys/netlink/route/rt.c
246

This one is new.
I've added it in 84bb3648d2151 for backward compatibility with dump_rc_nhop. :D

emaste accepted this revision.May 27 2026, 9:21 PM

Oops, MIN of course.

This revision is now accepted and ready to land.May 27 2026, 9:21 PM
markj accepted this revision.May 28 2026, 3:27 PM
Closed by commit rG97f7b21dd525: rtnetlink: Fix weight overflow in RTA_MULTIPATH (authored by pouria). · Explain WhyMay 28 2026, 8:01 PM
This revision was automatically updated to reflect the committed changes.
pouria added a commit: rG97f7b21dd525: rtnetlink: Fix weight overflow in RTA_MULTIPATH.
pouria mentioned this in D56750: netlink: store osreldate of the process in the netlink pcb.May 29 2026, 9:36 PM

Revision Contents
Changeset List

PathSize
sys/
netlink/
route/
5 lines

Diff 178713

View Options

sys/netlink/route/rt.c

Loading...