Paths

Table of Contentst

Differential D57010

sbin/ipfw: fix parsing error in nat config port_range
ClosedPublic
Actions

Authored by terehovv_mail.ru on May 15 2026, 9:59 AM.

Tags

None

Referenced Files

	F168899210: D57010.id177874.diff
	Sun, Aug 30, 4:14 PM

	F168898797: D57010.id178198.diff
	Sun, Aug 30, 4:11 PM

	F168769672: D57010.id177871.diff
	Sun, Aug 30, 1:45 AM

	F168769655: D57010.id178301.diff
	Sun, Aug 30, 1:45 AM

	Unknown Object (File)
	Sat, Aug 29, 11:26 PM

	Unknown Object (File)
	Sat, Aug 29, 1:57 PM

	Unknown Object (File)
	Fri, Aug 28, 1:53 PM

	Unknown Object (File)
	Fri, Aug 28, 10:18 AM

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

ae
lytboris_gmail.com

Commits

rGd2e63a095193: ipfw: fix parsing error in nat config port_range
rG33cafd3fadd0: ipfw: fix parsing error in nat config port_range
rG6eba055fcf5b: ipfw: fix parsing error in nat config port_range

Summary

This patch fixes a port range parsing error.
Unlike the patch from the PR, this patch uses strsep().

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263240

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

terehovv_mail.ru created this revision.May 15 2026, 9:59 AM

Herald added subscribers: donner, imp. · View Herald TranscriptMay 15 2026, 9:59 AM

terehovv_mail.ru requested review of this revision.May 15 2026, 9:59 AM

lytboris_gmail.com added reviewers: ae, lytboris_gmail.com.May 15 2026, 10:09 AM

Add diff context

Fix tests for nat:ipfw_portalias

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro. · View Herald TranscriptMay 16 2026, 11:58 AM

Added set -e to the test script to ensure it is correct

Code is fine, some finishing touches are needed.

sbin/ipfw/nat.c
765	I would use `base = 0` here, no reason to limit port range to be in decimal form.
766	ipfw.8 must be changed to reflect port range limits: port_range lower-upper Set the aliasing ports between the ranges given. Upper port has to be greater than lower.

Update ipfw.8 man page
Update strtol() to use base = 0

Herald added a subscriber: ziaee. · View Herald TranscriptMay 20 2026, 1:24 PM

lytboris_gmail.com accepted this revision.May 20 2026, 1:55 PM

This revision is now accepted and ready to land.May 20 2026, 1:55 PM

Closed by commit rG6eba055fcf5b: ipfw: fix parsing error in nat config port_range (authored by terehovv_mail.ru, committed by ae). · Explain WhyMay 21 2026, 8:11 AM

This revision was automatically updated to reflect the committed changes.

ae added a commit: rG6eba055fcf5b: ipfw: fix parsing error in nat config port_range.

ae added a commit: rG33cafd3fadd0: ipfw: fix parsing error in nat config port_range.May 29 2026, 8:03 AM

ae added a commit: rGd2e63a095193: ipfw: fix parsing error in nat config port_range.

Revision Contents
Changeset List

Path

Size

sbin/

ipfw/

20 lines

tests/

sys/

netpfil/

common/

24 lines

Diff 177920

sbin/ipfw/nat.c

Loading...

tests/sys/netpfil/common/nat.sh

Loading...