bq_insert: delay the BUF_UNLOCK if not bd_flush()ing
ClosedPublic
Actions

Authored by rlibby on May 11 2026, 7:42 PM.

Tags

None

Referenced Files

	F162263090: D56948.id177600.diff
	Sat, Jul 11, 11:52 AM

	Unknown Object (File)
	Sun, Jul 5, 1:40 PM

	Unknown Object (File)
	Wed, Jun 17, 9:35 AM

	Unknown Object (File)
	Jun 7 2026, 6:44 AM

	Unknown Object (File)
	Jun 4 2026, 12:11 PM

	Unknown Object (File)
	Jun 4 2026, 12:07 PM

	Unknown Object (File)
	Jun 4 2026, 7:46 AM

	Unknown Object (File)
	Jun 4 2026, 7:37 AM

View All 27 Files

Subscribers

imp

olce

Details

Reviewers

kib
markj
jeff

Commits

rG2a56cedac2e4: bq_insert: delay the BUF_UNLOCK if not bd_flush()ing

Summary

Reduce bufqueue lock contention by delaying the BUF_UNLOCK to after
dropping the bufqueue lock. Still do the early BUF_UNLOCK if we
actually have to bd_flush.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rlibby created this revision.May 11 2026, 7:42 PM

Herald added subscribers: olce, imp. · View Herald TranscriptMay 11 2026, 7:42 PM

rlibby requested review of this revision.May 11 2026, 7:42 PM

Harbormaster completed remote builds in B72990: Diff 177600.May 11 2026, 7:42 PM

rlibby added reviewers: kib, markj, jeff.May 11 2026, 7:44 PM

kib accepted this revision.May 11 2026, 7:48 PM

This revision is now accepted and ready to land.May 11 2026, 7:48 PM

markj accepted this revision.May 12 2026, 1:13 PM

Closed by commit rG2a56cedac2e4: bq_insert: delay the BUF_UNLOCK if not bd_flush()ing (authored by rlibby). · Explain WhyMay 13 2026, 5:45 PM

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rG2a56cedac2e4: bq_insert: delay the BUF_UNLOCK if not bd_flush()ing.

Revision Contents
Changeset List

Path

Size

sys/

kern/

vfs_bio.c

20 lines

Diff 177797

View Options

bq_insert: delay the BUF_UNLOCK if not bd_flush()ingClosedPublicActions