bq_insert: delay the BUF_UNLOCK if not bd_flush()ing
ClosedPublic
Actions

Authored by rlibby on May 11 2026, 7:42 PM.

Tags

None

Referenced Files

	F167139234: D56948.id177797.diff
	Wed, Aug 19, 10:21 AM

	Unknown Object (File)
	Tue, Aug 18, 4:09 PM

	Unknown Object (File)
	Tue, Aug 18, 5:47 AM

	Unknown Object (File)
	Wed, Aug 12, 11:56 PM

	Unknown Object (File)
	Wed, Aug 12, 7:04 PM

	Unknown Object (File)
	Mon, Aug 10, 12:26 PM

	Unknown Object (File)
	Mon, Aug 10, 8:31 AM

	Unknown Object (File)
	Sun, Aug 9, 2:03 AM

View All 44 Files

Subscribers

imp

olce

Details

Reviewers

kib
markj
jeff

Commits

rG2a56cedac2e4: bq_insert: delay the BUF_UNLOCK if not bd_flush()ing

Summary

Reduce bufqueue lock contention by delaying the BUF_UNLOCK to after
dropping the bufqueue lock. Still do the early BUF_UNLOCK if we
actually have to bd_flush.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rlibby created this revision.May 11 2026, 7:42 PM

Herald added subscribers: olce, imp. · View Herald TranscriptMay 11 2026, 7:42 PM

rlibby requested review of this revision.May 11 2026, 7:42 PM

Harbormaster completed remote builds in B72990: Diff 177600.May 11 2026, 7:42 PM

rlibby added reviewers: kib, markj, jeff.May 11 2026, 7:44 PM

kib accepted this revision.May 11 2026, 7:48 PM

This revision is now accepted and ready to land.May 11 2026, 7:48 PM

markj accepted this revision.May 12 2026, 1:13 PM

Closed by commit rG2a56cedac2e4: bq_insert: delay the BUF_UNLOCK if not bd_flush()ing (authored by rlibby). · Explain WhyMay 13 2026, 5:45 PM

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rG2a56cedac2e4: bq_insert: delay the BUF_UNLOCK if not bd_flush()ing.

Revision Contents
Changeset List

Path

Size

sys/

kern/

vfs_bio.c

20 lines

Diff 177797

View Options

bq_insert: delay the BUF_UNLOCK if not bd_flush()ingClosedPublicActions