linuxkpi: Add `struct xa_limit` support to xarray
Needs ReviewPublic
Actions

Authored by dumbbell on Thu, Apr 16, 9:07 PM.

Details

Reviewers

None

Group Reviewers

linuxkpi

Summary

The xa_alloc*() functions family takes a struct xa_limit to describe the range of IDs the caller wants to allocate. We were using a single mask to qualify a maximum ID only.

This commit changes that to use the same struct xa_limit. The logic did not change, except it now supports a minimum ID as well. The definition of XA_LIMIT() macro is adapted, as well as the definitions of xa_limit_* (only xa_limit_32b existed, the other two are added with this commit).

The DRM generic code started to use this struct xa_limit in Linux 6.12.

This is part of the update of DRM drivers to Linux 6.12.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dumbbell created this revision.Thu, Apr 16, 9:07 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptThu, Apr 16, 9:07 PM

dumbbell requested review of this revision.Thu, Apr 16, 9:07 PM

dumbbell added a parent revision: D56444: linuxkpi: Add `kmemdup_array()`.Thu, Apr 16, 9:29 PM

dumbbell added a child revision: D56446: linuxkpi: Define `DEFINE_XARRAY*()` macros.

This will definitively need a recompile. I hope really all callers used the xa_limit_32b macro before and no hard coded numbers. Thankfully we don't support any pre-5.1 drm-kmod so should be fine. I wonder how hps ended up implementing the old KPI there...

I believe its fine but a 2nd pair of eyes wouldn't hurt, especially on __xa_alloc_cyclic.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

xarray.h

26 lines

src/

linux_xarray.c

41 lines

Diff 175710

View Options

sys/compat/linuxkpi/common/include/linux/xarray.h