Page MenuHomeFreeBSD
Differential D56222

Update posix_spawn for POSIX 2024
ClosedPublic
Actions

Authored by kib on Thu, Apr 2, 8:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 17, 2:50 AM
Unknown Object (File)
Wed, Apr 15, 1:44 PM
Unknown Object (File)
Wed, Apr 15, 12:45 PM
Unknown Object (File)
Tue, Apr 14, 10:32 AM
Unknown Object (File)
Tue, Apr 14, 4:05 AM
Unknown Object (File)
Tue, Apr 14, 1:12 AM
Unknown Object (File)
Tue, Apr 14, 12:06 AM
Unknown Object (File)
Mon, Apr 13, 11:38 PM
View All 21 Files
Subscribers
imp
ziaee

Details

Reviewers
emaste
dim
ngie
Commits
rGe56858f05fd7: posix_spawn test: switch to POSIX spelling for addchdir and addfchdir
rGb7b485efac8c: posix_spawn_file_action_addopen.3: ignoring close failure is now approved
rG7caa71145c5e: posix_spawn: actions chdir and fchdir are now required by POSIX
Summary
posix_spawn_file_action_addopen.3: ignoring close failure is now approved


posix_spawn: actions chdir and fchdir are now required by POSIX

Drop the _np suffix.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib created this revision.Thu, Apr 2, 8:12 AM
Herald added subscribers: ziaee, imp. · View Herald TranscriptThu, Apr 2, 8:12 AM
kib requested review of this revision.Thu, Apr 2, 8:12 AM
dim accepted this revision.Thu, Apr 2, 7:25 PM

Apart from the manpage nits, LGTM.

lib/libc/gen/posix_spawn.3
449

This also needs a posix_spawn_file_actions_addchdir entry.

451

Hm, was this one also standardized?

This revision is now accepted and ready to land.Thu, Apr 2, 7:25 PM
kib updated this revision to Diff 174834.Fri, Apr 3, 3:05 AM
kib marked 2 inline comments as done.

Fix manpage.
Switch test to use non-_np names.

This revision now requires review to proceed.Fri, Apr 3, 3:05 AM
Herald added a reviewer: ngie. · View Herald TranscriptFri, Apr 3, 3:05 AM
dim accepted this revision.Fri, Apr 3, 7:45 AM

LGTM

This revision is now accepted and ready to land.Fri, Apr 3, 7:45 AM
Closed by commit rG7caa71145c5e: posix_spawn: actions chdir and fchdir are now required by POSIX (authored by kib). · Explain WhyFri, Apr 3, 8:23 AM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG7caa71145c5e: posix_spawn: actions chdir and fchdir are now required by POSIX.
kib added a commit: rGb7b485efac8c: posix_spawn_file_action_addopen.3: ignoring close failure is now approved.
kib added a commit: rGe56858f05fd7: posix_spawn test: switch to POSIX spelling for addchdir and addfchdir.
ngie added a comment.Thu, Apr 9, 3:41 AM

Thank you @kib !

Revision Contents
Changeset List

PathSize
4 lines
include/
4 lines
lib/
libc/
gen/
4 lines
2 lines
10 lines
5 lines
29 lines

Diff 174770

View Options

ObsoleteFiles.inc

Loading...
View Options

include/spawn.h

Loading...
View Options

lib/libc/gen/Makefile.inc

Loading...
View Options

lib/libc/gen/Symbol.map

Loading...
View Options

lib/libc/gen/posix_spawn.3

Loading...
View Options

lib/libc/gen/posix_spawn.c

Loading...
View Options

lib/libc/gen/posix_spawn_file_actions_addopen.3

Loading...