Page MenuHomeFreeBSD
Differential D55823

krb5: Use GNU strerror_r() when building on Linux
AbandonedPublic
Actions

Authored by cy on Thu, Mar 12, 3:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 20, 2:18 AM
Unknown Object (File)
Fri, Mar 20, 12:53 AM
Unknown Object (File)
Wed, Mar 18, 9:08 PM
Unknown Object (File)
Tue, Mar 17, 8:27 AM
Unknown Object (File)
Sat, Mar 14, 11:30 PM
Subscribers
imp
michaelo

Details

Reviewers
emaste
jrtc27
ivy
des
markj
jrm
Group Reviewers
krb5
Summary

While the POSIX (BSD) strerror_r() returns an int where 0 is success
or an error number on failure, the GNU strerror() returns a char*, with
NULL pointer on success or otherwise a pointer to an error message.
This difference causes a buildworld failure when building FreeBSD on a
Linux system.

34e7a57673c9 and 4dd2b869cd0 addressed the error by defining
STRERROR_R_CHAR_P when built on a Linux system. This patch tells
includes autoconf.h, which defines STRERROR_R_CHAR_P telling nKRB5's
strerror_p.c which form of the strerror() function to call.

Noted on an Ubuntu system. Tested on a Fedora system.

PR: 293660
MFC After: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71358
Build 68241: arc lint + arc unit

Event Timeline

cy created this revision.Thu, Mar 12, 3:28 AM
Herald added a subscriber: imp. · View Herald TranscriptThu, Mar 12, 3:28 AM
cy requested review of this revision.Thu, Mar 12, 3:28 AM
Harbormaster completed remote builds in B71358: Diff 173598.Thu, Mar 12, 3:28 AM
cy added a reviewer: krb5.Thu, Mar 12, 3:29 AM
michaelo added a subscriber: michaelo.Thu, Mar 12, 9:28 AM

Is this something which should be upstream?

cy added a comment.Thu, Mar 12, 12:08 PM
In D55823#1277079, @michaelo wrote:

Is this something which should be upstream?

Yes.

michaelo added a comment.Thu, Mar 12, 1:48 PM
In D55823#1277096, @cy wrote:
In D55823#1277079, @michaelo wrote:

Is this something which should be upstream?

Yes.

Do you want to raise the PR on GitHub or shall I do it? Greg Hudson is quite receptive to PRs. I have done numerous throughout the years.

emaste added a comment.Thu, Mar 12, 1:52 PM

I find it quite surprising that this would just be broken in the upstream build; is it possible this is an artifact of our bespoke build process? Presumably the Implement the POSIX strerror_r API in terms of the GNU strerror_r section has to be used on GNU systems?

cy added a comment.Thu, Mar 12, 2:20 PM
In D55823#1277119, @emaste wrote:

I find it quite surprising that this would just be broken in the upstream build; is it possible this is an artifact of our bespoke build process? Presumably the Implement the POSIX strerror_r API in terms of the GNU strerror_r section has to be used on GNU systems?

I find it surprising too.

However, jrtc27@'s patch to krb5/include/autoconf.h did not make it into 15.0-RELEASE. And, this patch relies on jrtc27@'s patch. I MFCed jrtc27@'s patch yesterday. This suggests this has been broken in the stable/15 branch until yesterday. Given all our work to add some "awareness" of build environment to autoconf.h (which BTW is built by ./configure upstream), our bespoke build environment would have contributed.

I'm also surprised we didn't notice until now.

My patch did apply to the upstream sources (PR #1494). I'll have to give it a spin on my Fedora VM at $JOB.

cy added a comment.Thu, Mar 12, 2:51 PM

I think this needs a little more investigation because k5-platform.h already includes autoconf.h. jrtc27@'s October patch should have been enough. I will rebuild again (cleanly).

cy abandoned this revision.Thu, Mar 12, 7:58 PM

Update to the latest 15-STABLE is all that is needed.

Revision Contents
Changeset List

PathSize
crypto/
krb5/
src/
util/
support/
1 line

Diff 173598

View Options

crypto/krb5/src/util/support/strerror_r.c

Loading...