libmd aarch64: Use ands instead of bics to round down the length
ClosedPublic
Actions

Authored by jhb on Sat, Feb 7, 3:46 PM.

Details

Reviewers

andrew
fuz

Commits

rG244f498074b5: libmd aarch64: Use ands instead of bics to round down the length

Summary

GNU as does not accept bics with two register operands but instead
requires three register operands. However, clang assembles the bics
instruction to ands anyway, so just use ands directly.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70491
Build 67374: arc lint + arc unit

Event Timeline

jhb created this revision.Sat, Feb 7, 3:46 PM

Herald added a reviewer: andrew. · View Herald TranscriptSat, Feb 7, 3:46 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

jhb requested review of this revision.Sat, Feb 7, 3:46 PM

jhb added a child revision: D55156: googletest: Link the gmock and gtest libraries against compiler_rt for aarch64.

jhb added a reviewer: fuz.Sat, Feb 7, 3:47 PM

Harbormaster completed remote builds in B70491: Diff 171409.Sat, Feb 7, 3:47 PM

If that is needed to fix the build, sure, why not.

This revision is now accepted and ready to land.Sat, Feb 7, 11:55 PM

Closed by commit rG244f498074b5: libmd aarch64: Use ands instead of bics to round down the length (authored by jhb). · Explain WhyMon, Feb 9, 4:28 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG244f498074b5: libmd aarch64: Use ands instead of bics to round down the length.

Revision Contents
Changeset List

Path

Size

lib/

libmd/

aarch64/

md5block.S

2 lines

Diff 171409

View Options

lib/libmd/aarch64/md5block.S

libmd aarch64: Use ands instead of bics to round down the lengthClosedPublicActions