Page MenuHomeFreeBSD
Differential D55110

diff: Fix integer overflows in Stone algorithm
ClosedPublic
Actions

Authored by des on Feb 4 2026, 6:35 PM.
Tags
None
Referenced Files
F154316656: D55110.id.diff
Mon, Apr 27, 7:21 PM
Unknown Object (File)
Wed, Apr 22, 1:39 AM
Unknown Object (File)
Fri, Apr 17, 1:35 AM
Unknown Object (File)
Wed, Apr 15, 12:26 PM
Unknown Object (File)
Wed, Apr 15, 8:09 AM
Unknown Object (File)
Sun, Apr 5, 3:59 AM
Unknown Object (File)
Sun, Apr 5, 1:45 AM
Unknown Object (File)
Mar 22 2026, 4:00 AM
View All 32 Files
Subscribers
imp

Details

Reviewers
thj
kevans
Group Reviewers
Klara
Commits
rG238bf5ebf684: diff: Fix integer overflows in Stone algorithm
rG2ae615c4f1d0: diff: Fix integer overflows in Stone algorithm
rG237fd8dd9697: diff: Fix integer overflows in Stone algorithm
rG4a30735cddad: diff: Fix integer overflows in Stone algorithm
rG5fc739eb5949: diff: Fix integer overflows in Stone algorithm
Summary

Fix integer overflows that may occur when the context window is very
large and add tests to exercise those conditions.

PR: 267032
MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Feb 4 2026, 6:35 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 4 2026, 6:35 PM
des requested review of this revision.Feb 4 2026, 6:35 PM
des added a parent revision: D55109: diff: Print an error message on I/O error.
Harbormaster completed remote builds in B70409: Diff 171165.Feb 4 2026, 6:35 PM
des added a child revision: D55111: diff: Add test case for pagination resource leak.Feb 4 2026, 6:35 PM
thj accepted this revision.Feb 5 2026, 1:01 PM
This revision is now accepted and ready to land.Feb 5 2026, 1:01 PM
kevans accepted this revision.Feb 5 2026, 2:23 PM
Closed by commit rG5fc739eb5949: diff: Fix integer overflows in Stone algorithm (authored by des). · Explain WhyFeb 5 2026, 2:46 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG5fc739eb5949: diff: Fix integer overflows in Stone algorithm.
des added a commit: rG4a30735cddad: diff: Fix integer overflows in Stone algorithm.Feb 10 2026, 3:27 PM
des added a commit: rG237fd8dd9697: diff: Fix integer overflows in Stone algorithm.
des added a commit: rG2ae615c4f1d0: diff: Fix integer overflows in Stone algorithm.
cperciva added a commit: rG238bf5ebf684: diff: Fix integer overflows in Stone algorithm.Feb 11 2026, 6:15 AM

Revision Contents
Changeset List

PathSize
usr.bin/
diff/
32 lines
tests/
33 lines

Diff 171220

View Options

usr.bin/diff/diffreg.c

Loading...
View Options

usr.bin/diff/tests/diff_test.sh

Loading...