libfetch: Check for failure to create SSL context
ClosedPublic
Actions

Authored by des on Wed, Feb 4, 10:36 AM.

Details

Reviewers

Commits

rG53e0a1d1ff9b: libfetch: Check for failure to create SSL context
rG767f1ebcf75e: libfetch: Check for failure to create SSL context
rG4781aeb5b9cb: libfetch: Check for failure to create SSL context
rGd653f474e901: libfetch: Check for failure to create SSL context
rG4e160c6197f7: libfetch: Check for failure to create SSL context

Summary

Drop the ssl_meth member, there is no reason to hang on to it.

Replace deprecated SSLv23_client_method() with TLS_client_method().

Check the return value from SSL_CTX_new().

MFC after: 1 week
PR: 292903

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70393
Build 67276: arc lint + arc unit

Event Timeline

des created this revision.Wed, Feb 4, 10:36 AM

Herald added a subscriber: imp. · View Herald TranscriptWed, Feb 4, 10:36 AM

des requested review of this revision.Wed, Feb 4, 10:36 AM

Harbormaster completed remote builds in B70393: Diff 171134.Wed, Feb 4, 10:36 AM

markj accepted this revision.Sat, Feb 7, 1:59 PM

This revision is now accepted and ready to land.Sat, Feb 7, 1:59 PM

Closed by commit rG4e160c6197f7: libfetch: Check for failure to create SSL context (authored by des). · Explain WhySat, Feb 7, 2:25 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG4e160c6197f7: libfetch: Check for failure to create SSL context.

des added a commit: rGd653f474e901: libfetch: Check for failure to create SSL context.Wed, Feb 11, 8:40 PM

des added a commit: rG4781aeb5b9cb: libfetch: Check for failure to create SSL context.

des added a commit: rG767f1ebcf75e: libfetch: Check for failure to create SSL context.Wed, Feb 11, 8:42 PM

cperciva added a commit: rG53e0a1d1ff9b: libfetch: Check for failure to create SSL context.Thu, Feb 12, 9:25 PM

Revision Contents
Changeset List

Path

Size

lib/

libfetch/

common.h

1 line

common.c

10 lines

Diff 171134

View Options

lib/libfetch/common.h