Paths

Table of Contentst

Differential D54598

arm64: Provide ifunc HWCAP structure definitions
AcceptedPublic
Actions

Authored by sarah.walker2_arm.com on Thu, Jan 8, 10:51 AM.

Tags

None

Referenced Files

	F141925659: D54598.diff
	Mon, Jan 12, 4:31 PM

	F141925046: D54598.id169312.diff
	Mon, Jan 12, 3:11 PM

	F141914631: D54598.diff
	Mon, Jan 12, 11:12 AM

	F141885964: D54598.diff
	Mon, Jan 12, 12:19 AM

	Unknown Object (File)
	Fri, Jan 9, 7:18 PM

	Unknown Object (File)
	Thu, Jan 8, 5:37 PM

	Unknown Object (File)
	Thu, Jan 8, 2:18 PM

	Unknown Object (File)
	Thu, Jan 8, 2:16 PM

View All 9 Files

Subscribers

Details

Reviewers

andrew
manu

Summary

IFUNC structure is based on Section 9.4.1 "GNU C Library IFUNC interface"
from "System V ABI for the Arm 64-bit Architecture (AArch64)", 2025Q1.
(https://github.com/ARM-software/abi-aa/releases/download/2025Q1/sysvabi64.pdf)

Sponsored by: Arm Ltd

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69712
Build 66595: arc lint + arc unit

Event Timeline

sarah.walker2_arm.com created this revision.Thu, Jan 8, 10:51 AM

Herald added a reviewer: andrew. · View Herald TranscriptThu, Jan 8, 10:51 AM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: emaste, imp. · View Herald Transcript

sarah.walker2_arm.com requested review of this revision.Thu, Jan 8, 10:51 AM

Harbormaster completed remote builds in B69712: Diff 169312.Thu, Jan 8, 10:51 AM

sarah.walker2_arm.com mentioned this in D54559: rtld-elf: Pass HWCAP flags to ifunc resolver functions.Thu, Jan 8, 10:56 AM

andrew added inline comments.Thu, Jan 8, 12:06 PM

sys/arm64/include/ifunc.h
55–56	These can still be marked as `__unused`. It just tells the compiler to not complain if the arg isn't used in the function.

jrtc27 added a subscriber: jrtc27.Thu, Jan 8, 3:49 PM

jrtc27 added inline comments.

sys/arm64/include/ifunc.h
55–56	s/can/must/ otherwise you require them to be used by everything using DEFINE_UIFUNC

jrtc27 added inline comments.Thu, Jan 8, 3:51 PM

sys/arm64/include/ifunc.h
32	Still no glibc-compatible typedef?
34	__size_t?

jrtc27 added inline comments.Thu, Jan 8, 3:53 PM

sys/arm64/include/ifunc.h
41	This is ULL but a_val is unsigned long?
41	(well, a_val is long but _hwcap is unsigned long)

sarah.walker2_arm.com added inline comments.Thu, Jan 8, 4:28 PM

sys/arm64/include/ifunc.h
34	_size is unsigned long in the ABI spec. Do you want me to deviate from that for this definition?
41	Again, this is 1ULL in the ABI spec.

jrtc27 added inline comments.Thu, Jan 8, 4:35 PM

sys/arm64/include/ifunc.h
34	Hm, ok
41	That's a strange spec. Presumably that was done for ILP32, but that doesn't make any sense with auxargs and __ifunc_arg_t members being unsigned long. But ok, if that's the nonsense it says then we go with that...

Address review comments.

Harbormaster completed remote builds in B69759: Diff 169398.Fri, Jan 9, 4:03 PM

sarah.walker2_arm.com mentioned this in D54560: libc/aarch64: Use MOPS implementations of memcpy/memmove/memset where availble.Fri, Jan 9, 4:57 PM

Make ifunc_arg argument const.

Harbormaster completed remote builds in B69816: Diff 169508.Mon, Jan 12, 9:42 AM

andrew accepted this revision.Mon, Jan 12, 10:51 AM

This revision is now accepted and ready to land.Mon, Jan 12, 10:51 AM

jrtc27 added inline comments.Mon, Jan 12, 2:12 PM

sys/arm64/include/ifunc.h
38	These are all improperly indented

Indentation fixes.

This revision now requires review to proceed.Mon, Jan 12, 2:32 PM

Harbormaster completed remote builds in B69822: Diff 169518.Mon, Jan 12, 2:32 PM

andrew accepted this revision.Mon, Jan 12, 4:51 PM

This revision is now accepted and ready to land.Mon, Jan 12, 4:51 PM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

include/

26 lines

Diff 169312

sys/arm64/include/ifunc.h

Loading...