Page MenuHomeFreeBSD
Differential D54507

rtld: Use a helper variable to simplify a few lines
ClosedPublic
Actions

Authored by jhb on Jan 4 2026, 9:45 PM.
Tags
None
Referenced Files
F172438063: D54507.id169027.diff
Fri, Sep 18, 11:26 AM
Unknown Object (File)
Thu, Sep 17, 7:37 PM
Unknown Object (File)
Thu, Sep 17, 7:31 PM
Unknown Object (File)
Thu, Sep 17, 7:28 PM
Unknown Object (File)
Thu, Sep 17, 7:25 PM
Unknown Object (File)
Wed, Sep 16, 1:03 AM
Unknown Object (File)
Thu, Sep 10, 10:51 AM
Unknown Object (File)
Wed, Sep 9, 4:41 PM
View All Files
Subscribers
bdragon
imp

Details

Reviewers
jrtc27
kib
Commits
rGc57d2b6f97d2: rtld: Use a helper variable to simplify a few lines
rG6d6bf4a892d6: rtld: Use a helper variable to simplify a few lines

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69607
Build 66490: arc lint + arc unit

Event Timeline

jhb created this revision.Jan 4 2026, 9:45 PM
Herald added subscribers: bdragon, imp. · View Herald TranscriptJan 4 2026, 9:45 PM
jhb requested review of this revision.Jan 4 2026, 9:45 PM
Harbormaster completed remote builds in B69607: Diff 169027.Jan 4 2026, 9:45 PM
jhb added inline comments.Jan 13 2026, 3:54 PM
libexec/rtld-elf/rtld.c
5502

Not sure if pad is quite the right name for this region? But given it's zeroed, that was the best guess I had for it.

jhb added a reviewer: kib.Jan 14 2026, 4:30 PM
jrtc27 added inline comments.Jan 14 2026, 4:33 PM
libexec/rtld-elf/rtld.c
5502

tls_bss_offset? Given generally arises from .tbss.

kib accepted this revision.Jan 14 2026, 6:24 PM

I am fine with jrtc27' suggested name.

This revision is now accepted and ready to land.Jan 14 2026, 6:24 PM
jhb updated this revision to Diff 169740.Jan 14 2026, 8:04 PM

Rename variable

This revision now requires review to proceed.Jan 14 2026, 8:04 PM
Harbormaster completed remote builds in B69891: Diff 169740.Jan 14 2026, 8:04 PM
kib accepted this revision.Jan 15 2026, 3:58 AM
This revision is now accepted and ready to land.Jan 15 2026, 3:58 AM
Closed by commit rG6d6bf4a892d6: rtld: Use a helper variable to simplify a few lines (authored by jhb). · Explain WhyJan 15 2026, 6:24 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG6d6bf4a892d6: rtld: Use a helper variable to simplify a few lines.
jhb added a commit: rGc57d2b6f97d2: rtld: Use a helper variable to simplify a few lines.Apr 24 2026, 3:29 PM

Revision Contents
Changeset List

PathSize
libexec/
rtld-elf/
11 lines

Diff 169027

View Options

libexec/rtld-elf/rtld.c

Loading...