rtld: Use a helper variable to simplify a few lines
ClosedPublic
Actions

Authored by jhb on Sun, Jan 4, 9:45 PM.

Details

Reviewers

jrtc27
kib

Commits

rG6d6bf4a892d6: rtld: Use a helper variable to simplify a few lines

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69607
Build 66490: arc lint + arc unit

Event Timeline

jhb created this revision.Sun, Jan 4, 9:45 PM

Herald added subscribers: bdragon, imp. · View Herald TranscriptSun, Jan 4, 9:45 PM

jhb requested review of this revision.Sun, Jan 4, 9:45 PM

Harbormaster completed remote builds in B69607: Diff 169027.Sun, Jan 4, 9:45 PM

jhb added inline comments.Tue, Jan 13, 3:54 PM

libexec/rtld-elf/rtld.c
5502	Not sure if `pad` is quite the right name for this region? But given it's zeroed, that was the best guess I had for it.

jhb added a reviewer: kib.Wed, Jan 14, 4:30 PM

jrtc27 added inline comments.Wed, Jan 14, 4:33 PM

libexec/rtld-elf/rtld.c
5502	tls_bss_offset? Given generally arises from .tbss.

I am fine with jrtc27' suggested name.

This revision is now accepted and ready to land.Wed, Jan 14, 6:24 PM

Rename variable

This revision now requires review to proceed.Wed, Jan 14, 8:04 PM

Harbormaster completed remote builds in B69891: Diff 169740.Wed, Jan 14, 8:04 PM

kib accepted this revision.Thu, Jan 15, 3:58 AM

This revision is now accepted and ready to land.Thu, Jan 15, 3:58 AM

Closed by commit rG6d6bf4a892d6: rtld: Use a helper variable to simplify a few lines (authored by jhb). · Explain WhyThu, Jan 15, 6:24 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG6d6bf4a892d6: rtld: Use a helper variable to simplify a few lines.

Revision Contents
Changeset List

Path

Size

libexec/

rtld-elf/

rtld.c

11 lines

Diff 169027

View Options

rtld: Use a helper variable to simplify a few linesClosedPublicActions