Differential D52532

libfetch: Fix -Wunterminated-string-initialization
ClosedPublic
Actions

Authored by arichardson on Sep 14 2025, 10:55 PM.

Tags

None

Referenced Files

	F173393147: D52532.id.diff
	Fri, Sep 25, 4:20 PM

	Unknown Object (File)
	Tue, Sep 22, 4:06 PM

	Unknown Object (File)
	Mon, Sep 21, 9:32 AM

	Unknown Object (File)
	Sun, Sep 20, 1:36 PM

	Unknown Object (File)
	Fri, Sep 11, 1:53 AM

	Unknown Object (File)
	Wed, Sep 2, 2:25 PM

	Unknown Object (File)
	Wed, Sep 2, 2:11 PM

	Unknown Object (File)
	Wed, Sep 2, 1:49 PM

Subscribers

Details

Reviewers

emaste
jhb
jrtc27

Commits

rGec6249ff56d8: libfetch: Fix -Wunterminated-string-initialization
rG27a7b982ba6e: libfetch: Fix -Wunterminated-string-initialization
rG79f578531f21: libfetch: Fix -Wunterminated-string-initialization

Summary

This defaults to an error in clang HEAD, use a char-by-char
initializer instead.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson created this revision.Sep 14 2025, 10:55 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 14 2025, 10:55 PM

arichardson requested review of this revision.Sep 14 2025, 10:55 PM

Harbormaster completed remote builds in B67024: Diff 162025.Sep 14 2025, 10:55 PM

rebase

Harbormaster completed remote builds in B67068: Diff 162126.Sep 15 2025, 11:33 PM

I guess this is shorter than using the new attribute.

This revision is now accepted and ready to land.Oct 28 2025, 6:41 PM

Fine by me, it's clear enough.

Closed by commit rG79f578531f21: libfetch: Fix -Wunterminated-string-initialization (authored by arichardson). · Explain WhyDec 16 2025, 8:23 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rG79f578531f21: libfetch: Fix -Wunterminated-string-initialization.

jhb added a commit: rG27a7b982ba6e: libfetch: Fix -Wunterminated-string-initialization.Apr 24 2026, 3:30 PM

dim added a commit: rGec6249ff56d8: libfetch: Fix -Wunterminated-string-initialization.May 29 2026, 12:23 PM

Revision Contents
Changeset List

Path

Size

lib/

libfetch/

2 lines

Diff 168223

lib/libfetch/common.c

Loading...