Page MenuHomeFreeBSD
Differential D52532

libfetch: Fix -Wunterminated-string-initialization
ClosedPublic
Actions

Authored by arichardson on Sep 14 2025, 10:55 PM.
Tags
None
Referenced Files
F159498391: D52532.id168223.diff
Sun, Jun 14, 10:56 PM
Unknown Object (File)
Sat, Jun 6, 5:11 PM
Unknown Object (File)
Wed, Jun 3, 11:34 AM
Unknown Object (File)
Wed, Jun 3, 10:16 AM
Unknown Object (File)
Wed, Jun 3, 8:58 AM
Unknown Object (File)
Tue, Jun 2, 1:25 PM
Unknown Object (File)
May 15 2026, 2:30 PM
Unknown Object (File)
May 15 2026, 9:36 AM
View All Files
Subscribers
imp

Details

Reviewers
emaste
jhb
jrtc27
Commits
rGec6249ff56d8: libfetch: Fix -Wunterminated-string-initialization
rG27a7b982ba6e: libfetch: Fix -Wunterminated-string-initialization
rG79f578531f21: libfetch: Fix -Wunterminated-string-initialization
Summary

This defaults to an error in clang HEAD, use a char-by-char
initializer instead.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 67068
Build 63951: arc lint + arc unit

Event Timeline

arichardson created this revision.Sep 14 2025, 10:55 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 14 2025, 10:55 PM
arichardson requested review of this revision.Sep 14 2025, 10:55 PM
Harbormaster completed remote builds in B67024: Diff 162025.Sep 14 2025, 10:55 PM
arichardson updated this revision to Diff 162126.Sep 15 2025, 11:33 PM

rebase

Harbormaster completed remote builds in B67068: Diff 162126.Sep 15 2025, 11:33 PM
jhb accepted this revision.Oct 28 2025, 6:41 PM

I guess this is shorter than using the new attribute.

This revision is now accepted and ready to land.Oct 28 2025, 6:41 PM
emaste accepted this revision.Oct 28 2025, 6:45 PM

Fine by me, it's clear enough.

Closed by commit rG79f578531f21: libfetch: Fix -Wunterminated-string-initialization (authored by arichardson). · Explain WhyDec 16 2025, 8:23 PM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rG79f578531f21: libfetch: Fix -Wunterminated-string-initialization.
jhb added a commit: rG27a7b982ba6e: libfetch: Fix -Wunterminated-string-initialization.Apr 24 2026, 3:30 PM
dim added a commit: rGec6249ff56d8: libfetch: Fix -Wunterminated-string-initialization.Fri, May 29, 12:23 PM

Revision Contents
Changeset List

PathSize
lib/
libfetch/
2 lines

Diff 162126

View Options

lib/libfetch/common.c

Loading...