Differential D54232

ipf: copy{in,out}ptr -> ipf_copy{in,out}_indirect
ClosedPublic
Actions

Authored by brooks on Mon, Dec 15, 1:50 PM.

Details

Reviewers

Group Reviewers

cheri

Commits

rGa79e2278c58e: ipf: copy{in,out}ptr -> ipf_copy{in,out}_indirect

Summary

These functions take the source or destintation address indirectly from
a potentially missaligned buffer. Rename them to refect this and to
free up the copy{in,out}ptr names.

Some of the code in question is dead code and doesn't or won't compile,
but I've changed it all for consistency.

NB: If the pointers are actually stored under aligned then this code is
broken with CHERI.

Effort: CHERI upstreaming
Sponsored by: Innovate UK

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 69269
Build 66152: arc lint + arc unit

Event Timeline

brooks created this revision.Mon, Dec 15, 1:50 PM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro, imp. · View Herald TranscriptMon, Dec 15, 1:50 PM

brooks requested review of this revision.Mon, Dec 15, 1:50 PM

Harbormaster completed remote builds in B69269: Diff 168046.Mon, Dec 15, 1:50 PM

Herald added a reviewer: cheri. · View Herald TranscriptMon, Dec 15, 1:50 PM

Herald added a reviewer: cheri. · View Herald Transcript

emaste added a subscriber: emaste.Mon, Dec 15, 2:00 PM

These names aren't generic and I'd like to use them for copy{in,out} variants that explicitly preserve pointer provenance as part of the CHERI import (we currently use copy{in,out}cap in CheriBSD to preserved pointer provenance when pointers are implemented as CHERI capabilities, but think it's better to talk about pointers rather than capabilities which have too many meanings even within the tree.)

Why not properly namespace these with an ipf_ prefix whilst you're at it?

lgtm

This revision is now accepted and ready to land.Mon, Dec 15, 9:18 PM

In D54232#1239061, @jrtc27 wrote:

Why not properly namespace these with an ipf_ prefix whilst you're at it?

Good point.

Also please MFC this.

brooks retitled this revision from ipf: copy{in,out}ptr -> copy{in,out}_indirect to ipf: copy{in,out}ptr -> ipf_copy{in,out}_indirect.Tue, Dec 16, 4:15 PM

prefix functions with ipf_

This revision now requires review to proceed.Tue, Dec 16, 4:15 PM

Harbormaster completed remote builds in B69303: Diff 168200.Tue, Dec 16, 4:15 PM

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Dec 19, 3:59 PM

Closed by commit rGa79e2278c58e: ipf: copy{in,out}ptr -> ipf_copy{in,out}_indirect (authored by brooks). · Explain Why

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rGa79e2278c58e: ipf: copy{in,out}ptr -> ipf_copy{in,out}_indirect.