ipf: copy{in,out}ptr -> ipf_copy{in,out}_indirect

[brooks]

Summary

These functions take the source or destintation address indirectly from
a potentially missaligned buffer. Rename them to refect this and to
free up the copy{in,out}ptr names.

Some of the code in question is dead code and doesn't or won't compile,
but I've changed it all for consistency.

NB: If the pointers are actually stored under aligned then this code is
broken with CHERI.

Effort: CHERI upstreaming
Sponsored by: Innovate UK

[brooks]

These names aren't generic and I'd like to use them for copy{in,out} variants that explicitly preserve pointer provenance as part of the CHERI import (we currently use copy{in,out}cap in CheriBSD to preserved pointer provenance when pointers are implemented as CHERI capabilities, but think it's better to talk about pointers rather than capabilities which have too many meanings even within the tree.)

[jrtc27]

Why not properly namespace these with an ipf_ prefix whilst you're at it?

[cy]

[cy]

In D54232#1239061, @jrtc27 wrote:

Why not properly namespace these with an ipf_ prefix whilst you're at it?

Good point.

[cy]

Also please MFC this.

[brooks]

prefix functions with ipf_