Page MenuHomeFreeBSD
Differential D54022

riscv/pmap: Handle superpages in pmap_extract_and_hold()
ClosedPublic
Actions

Authored by markj on Dec 1 2025, 9:53 PM.
Tags
None
Referenced Files
F167234198: D54022.id167390.diff
Thu, Aug 20, 5:02 AM
Unknown Object (File)
Sat, Aug 15, 12:39 PM
Unknown Object (File)
Thu, Aug 13, 7:19 PM
Unknown Object (File)
Wed, Aug 12, 6:24 AM
Unknown Object (File)
Wed, Aug 12, 4:00 AM
Unknown Object (File)
Tue, Aug 11, 10:43 PM
Unknown Object (File)
Tue, Aug 11, 4:20 PM
Unknown Object (File)
Tue, Aug 11, 3:21 PM
View All Files
Subscribers
imp
riscv

Details

Reviewers
kib
alc
Group Reviewers
riscv
Commits
rGf50f8cbb401b: riscv/pmap: Handle superpages in pmap_extract_and_hold()
rG20a0a2f8f36f: riscv/pmap: Handle superpages in pmap_extract_and_hold()
Summary

Without this change, vm_fault_quick_hold_pages() falls back to the slow
fault handler() when it encounters a superpage mapping.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Dec 1 2025, 9:53 PM
Herald added subscribers: riscv, imp. · View Herald TranscriptDec 1 2025, 9:53 PM
markj requested review of this revision.Dec 1 2025, 9:53 PM
Harbormaster completed remote builds in B68972: Diff 167388.Dec 1 2025, 9:53 PM
markj updated this revision to Diff 167389.Dec 1 2025, 9:55 PM

Return failure if the L2 entry is invalid

Harbormaster completed remote builds in B68973: Diff 167389.Dec 1 2025, 9:55 PM
markj updated this revision to Diff 167390.Dec 1 2025, 9:56 PM

Fix handling of insufficient permissions.

Harbormaster completed remote builds in B68974: Diff 167390.Dec 1 2025, 9:56 PM
markj edited the summary of this revision. (Show Details)Dec 1 2025, 10:02 PM
markj added a reviewer: riscv.
markj edited the summary of this revision. (Show Details)Dec 1 2025, 10:05 PM
markj added reviewers: kib, alc.Dec 1 2025, 10:08 PM
kib accepted this revision.Dec 1 2025, 10:15 PM
This revision is now accepted and ready to land.Dec 1 2025, 10:15 PM
alc added inline comments.Dec 2 2025, 5:28 PM
sys/riscv/riscv/pmap.c
1142–1143

The l3p != NULL is now redundant.

1143–1155

This goto is redundant.

markj updated this revision to Diff 167437.Dec 2 2025, 5:34 PM
markj marked 2 inline comments as done.

Handle Alan's comments.

This revision now requires review to proceed.Dec 2 2025, 5:34 PM
Harbormaster completed remote builds in B69001: Diff 167437.Dec 2 2025, 5:34 PM
alc accepted this revision.Dec 2 2025, 5:36 PM
This revision is now accepted and ready to land.Dec 2 2025, 5:36 PM
kib accepted this revision.Dec 2 2025, 10:15 PM
kib added inline comments.
sys/riscv/riscv/pmap.c
1159

Then this part could become just under 'else' and then goto is not needed at all.
But the current version is fine as well.

markj updated this revision to Diff 167445.Dec 2 2025, 11:27 PM
markj marked an inline comment as done.

Avoid gotos

This revision now requires review to proceed.Dec 2 2025, 11:27 PM
Harbormaster completed remote builds in B69005: Diff 167445.Dec 2 2025, 11:27 PM
kib accepted this revision.Dec 2 2025, 11:45 PM

Thanks.

This revision is now accepted and ready to land.Dec 2 2025, 11:45 PM
alc accepted this revision.Dec 3 2025, 8:44 AM
Closed by commit rG20a0a2f8f36f: riscv/pmap: Handle superpages in pmap_extract_and_hold() (authored by markj). · Explain WhyDec 3 2025, 2:44 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG20a0a2f8f36f: riscv/pmap: Handle superpages in pmap_extract_and_hold().
markj added a commit: rGf50f8cbb401b: riscv/pmap: Handle superpages in pmap_extract_and_hold().Dec 11 2025, 6:06 PM

Revision Contents
Changeset List

PathSize
sys/
riscv/
riscv/
22 lines

Diff 167473

View Options

sys/riscv/riscv/pmap.c

Loading...