Paths

Table of Contentst

Differential D53868

bpf: calculate net.bpf.stats buffer size dynamically
ClosedPublic
Actions

Authored by glebius on Nov 21 2025, 10:56 PM.

Tags

None

Referenced Files

	F153175936: D53868.diff
	Sun, Apr 19, 3:08 PM

	F153124625: D53868.id.diff
	Sun, Apr 19, 8:13 AM

	Unknown Object (File)
	Mon, Apr 13, 8:36 PM

	Unknown Object (File)
	Sat, Apr 11, 1:38 PM

	Unknown Object (File)
	Sat, Apr 4, 9:28 AM

	Unknown Object (File)
	Wed, Apr 1, 4:55 AM

	Unknown Object (File)
	Sat, Mar 28, 8:48 AM

	Unknown Object (File)
	Thu, Mar 26, 7:24 PM

View All 44 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG845896655815: bpf: calculate net.bpf.stats buffer size dynamically

Summary

This removed the global counter, that was updated in a racy manner.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68836
Build 65719: arc lint + arc unit

Event Timeline

glebius created this revision.Nov 21 2025, 10:56 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptNov 21 2025, 10:56 PM

glebius requested review of this revision.Nov 21 2025, 10:56 PM

Harbormaster completed remote builds in B68794: Diff 166928.Nov 21 2025, 10:56 PM

glebius added a parent revision: D53867: bpf: retire struct bpf_if_ext.Nov 21 2025, 10:56 PM

glebius added a child revision: D53869: bpf: global bpf list doesn't need CK.

markj added a subscriber: markj.Nov 24 2025, 10:13 PM

markj added inline comments.

sys/net/bpf.c
3091	Why not allocate `bpfd_cnt * sizeof(*xbd)` bytes instead? `req->oldlen` is not clamped, I believe, so userspace can request any allocation size they want.

Apply Mark's suggestion

Harbormaster completed remote builds in B68836: Diff 167070.Nov 25 2025, 6:05 AM

glebius marked an inline comment as done.Nov 25 2025, 6:05 AM

markj accepted this revision as: markj.Nov 25 2025, 2:00 PM

markj added inline comments.

sys/net/bpf.c
3094	To be useful, this assertion should be inside the inner loops below.

This revision is now accepted and ready to land.Nov 25 2025, 2:00 PM

Closed by commit rG845896655815: bpf: calculate net.bpf.stats buffer size dynamically (authored by glebius). · Explain WhyDec 3 2025, 11:20 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG845896655815: bpf: calculate net.bpf.stats buffer size dynamically.

Revision Contents
Changeset List

Path

Size

sys/

net/

27 lines

Diff 167070

sys/net/bpf.c

Loading...