Details

Reviewers

markj
des
adrian

Summary

This adds unit tests for all 70 functions in <stdbit.h>.

I'm sorry for the test framework, but it makes it so I don't
have to write 70 unit tests by hand.

Test Plan

This is the test plan for D53657.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 68740
Build 65623: arc lint + arc unit

Event Timeline

fuz created this revision.Mon, Nov 10, 9:35 AM

Herald added a subscriber: imp. · View Herald TranscriptMon, Nov 10, 9:35 AM

fuz requested review of this revision.Mon, Nov 10, 9:35 AM

Harbormaster completed remote builds in B68500: Diff 166114.Mon, Nov 10, 9:35 AM

fuz added a parent revision: D53657: libc: implement C23 <stdbit.h> functions.Mon, Nov 10, 9:35 AM

libc/tests/Makefile: use tab, not space for indent
libc/tests/stdbit: remove - from /*-

Harbormaster completed remote builds in B68544: Diff 166242.Tue, Nov 11, 3:55 PM

fuz mentioned this in D53657: libc: implement C23 <stdbit.h> functions.Tue, Nov 18, 2:43 PM

absolutely amazing use of macros and included source files i love it

This revision is now accepted and ready to land.Tue, Nov 18, 3:08 PM

des accepted this revision.Wed, Nov 19, 12:32 AM

des added inline comments.

lib/libc/tests/stdbit/stdbit-test-framework.c
64	no longer needed
lib/libc/tests/stdbit/stdbit-test-kernel.c
41
48

fuz added inline comments.Wed, Nov 19, 10:37 AM

lib/libc/tests/stdbit/stdbit-test-framework.c
64	If I remove `ATF_TP_ADD_TCS`, the tests fail to build (undefined symbol `main`). If I just remove the individual test cases `ATF_TP_ADD_TC`, then no unit tests end up defined. I am confused as to which part of this is “no longer needed.” Please clarify.

fix formatting issues in stdbit unit tests

This revision now requires review to proceed.Wed, Nov 19, 11:23 AM

Harbormaster completed remote builds in B68735: Diff 166764.Wed, Nov 19, 11:23 AM

use _WIDTH macros from C23 <limits.h> in stdbit unit tests, see D53825

Harbormaster completed remote builds in B68740: Diff 166769.Wed, Nov 19, 1:09 PM

I just remembered that you need to add an stdbit directory to etc/mtree/BSD.tests.mk:

--- a/etc/mtree/BSD.tests.dist
+++ b/etc/mtree/BSD.tests.dist
@@ -382,6 +382,8 @@
             ..
             ssp
             ..
+            stdbit
+            ..
             stdio
             ..
             stdlib

This revision now requires changes to proceed.Wed, Nov 19, 2:05 PM

Thanks, this is something I always forget about.

etc/mtree: add stdbit directory to etc/mtree/BSD.tests.mk

Herald added a subscriber: ivy. · View Herald TranscriptWed, Nov 19, 2:59 PM

Harbormaster completed remote builds in B68741: Diff 166775.Wed, Nov 19, 2:59 PM

libc/tests: add stdbit test framework and unit tests
Needs ReviewPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 166769

lib/libc/tests/Makefile

lib/libc/tests/stdbit/Makefile

lib/libc/tests/stdbit/stdbit-test-framework.c

lib/libc/tests/stdbit/stdbit-test-kernel.c

lib/libc/tests/stdbit/stdc_bit_ceil_test.c

lib/libc/tests/stdbit/stdc_bit_floor_test.c

lib/libc/tests/stdbit/stdc_bit_width_test.c

lib/libc/tests/stdbit/stdc_count_ones_test.c

lib/libc/tests/stdbit/stdc_count_zeros_test.c

lib/libc/tests/stdbit/stdc_first_leading_one_test.c

lib/libc/tests/stdbit/stdc_first_leading_zero_test.c

lib/libc/tests/stdbit/stdc_first_trailing_one_test.c

lib/libc/tests/stdbit/stdc_first_trailing_zero_test.c

lib/libc/tests/stdbit/stdc_has_single_bit_test.c

lib/libc/tests/stdbit/stdc_leading_ones_test.c

lib/libc/tests/stdbit/stdc_leading_zeros_test.c

lib/libc/tests/stdbit/stdc_trailing_ones_test.c

lib/libc/tests/stdbit/stdc_trailing_zeros_test.c

libc/tests: add stdbit test framework and unit testsNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 166769

lib/libc/tests/Makefile

lib/libc/tests/stdbit/Makefile

lib/libc/tests/stdbit/stdbit-test-framework.c

lib/libc/tests/stdbit/stdbit-test-kernel.c

lib/libc/tests/stdbit/stdc_bit_ceil_test.c

lib/libc/tests/stdbit/stdc_bit_floor_test.c

lib/libc/tests/stdbit/stdc_bit_width_test.c

lib/libc/tests/stdbit/stdc_count_ones_test.c

lib/libc/tests/stdbit/stdc_count_zeros_test.c

lib/libc/tests/stdbit/stdc_first_leading_one_test.c

lib/libc/tests/stdbit/stdc_first_leading_zero_test.c

lib/libc/tests/stdbit/stdc_first_trailing_one_test.c

lib/libc/tests/stdbit/stdc_first_trailing_zero_test.c

lib/libc/tests/stdbit/stdc_has_single_bit_test.c

lib/libc/tests/stdbit/stdc_leading_ones_test.c

lib/libc/tests/stdbit/stdc_leading_zeros_test.c

lib/libc/tests/stdbit/stdc_trailing_ones_test.c

lib/libc/tests/stdbit/stdc_trailing_zeros_test.c

libc/tests: add stdbit test framework and unit tests
Needs ReviewPublic
Actions

Revision Contents
Changeset List