Page MenuHomeFreeBSD
Differential D53659

libc/stdbit: add man pages for stdbit functions
Needs ReviewPublic
Actions

Authored by fuz on Mon, Nov 10, 9:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 18, 6:18 AM
Unknown Object (File)
Tue, Nov 18, 6:17 AM
Unknown Object (File)
Tue, Nov 18, 6:17 AM
Unknown Object (File)
Tue, Nov 18, 6:17 AM
Unknown Object (File)
Tue, Nov 18, 6:16 AM
Unknown Object (File)
Sun, Nov 16, 5:41 PM
Unknown Object (File)
Sat, Nov 15, 3:38 PM
Unknown Object (File)
Fri, Nov 14, 6:34 PM
View All 22 Files
Subscribers
imp
kib
pauamma_gundo.com
ziaee

Details

Reviewers
markj
kib
Group Reviewers
manpages
Summary

This adds man pages for each group of functions in <stdbit.h>.
The man pages have cross references to one-another.
Cross references from external man pages to these will be added
in a later DR.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 68499
Build 65382: arc lint + arc unit

Event Timeline

fuz created this revision.Mon, Nov 10, 9:33 AM
Herald added subscribers: ziaee, imp. · View Herald TranscriptMon, Nov 10, 9:33 AM
fuz requested review of this revision.Mon, Nov 10, 9:33 AM
Harbormaster completed remote builds in B68499: Diff 166113.Mon, Nov 10, 9:33 AM
fuz added a parent revision: D53658: man/man3: add stdbit.3.Mon, Nov 10, 9:35 AM
fuz added a child revision: D53661: man/man3: add cross references to stdbit(3).Mon, Nov 10, 9:46 AM
fuz updated this revision to Diff 166131.EditedMon, Nov 10, 2:21 PM
Harbormaster completed remote builds in B68507: Diff 166131.Mon, Nov 10, 2:21 PM
fuz mentioned this in D53657: libc: implement C23 <stdbit.h> functions.Tue, Nov 11, 3:25 PM
fuz updated this revision to Diff 166241.Tue, Nov 11, 3:53 PM
  • libc/stdbit: add - from .\"- in man pages
Harbormaster completed remote builds in B68543: Diff 166241.Tue, Nov 11, 3:53 PM
ziaee added inline comments.Tue, Nov 11, 4:08 PM
lib/libc/stdbit/stdc_bit_ceil.3
63

What are you doing with these \~?

fuz added inline comments.Tue, Nov 11, 4:29 PM
lib/libc/stdbit/stdc_bit_ceil.3
63

This prevents an awkward line break.

pauamma_gundo.com added a subscriber: pauamma_gundo.com.Wed, Nov 12, 3:04 AM

English LGTM. I can't speak to consistency with implementation or standard.

fuz mentioned this in D53658: man/man3: add stdbit.3.Wed, Nov 12, 10:36 AM
kib accepted this revision.Fri, Nov 14, 1:12 AM
kib added a subscriber: kib.
kib added inline comments.
lib/libc/stdbit/Makefile.inc
34

Order them alphabetically

This revision is now accepted and ready to land.Fri, Nov 14, 1:12 AM
fuz updated this revision to Diff 166694.Tue, Nov 18, 5:31 PM
  • sort MAN entries alphabetically as requested by @kib
This revision now requires review to proceed.Tue, Nov 18, 5:31 PM
Harbormaster completed remote builds in B68715: Diff 166694.Tue, Nov 18, 5:31 PM
fuz updated this revision to Diff 166763.Wed, Nov 19, 11:23 AM
  • add missing backslash in Makefile.inc
Harbormaster completed remote builds in B68734: Diff 166763.Wed, Nov 19, 11:23 AM

Revision Contents
Changeset List

Diff 166113

View Options

lib/libc/stdbit/Makefile.inc

Loading...
View Options

lib/libc/stdbit/stdc_bit_ceil.3

Loading...
View Options

lib/libc/stdbit/stdc_bit_floor.3

Loading...
View Options

lib/libc/stdbit/stdc_bit_width.3

Loading...
View Options

lib/libc/stdbit/stdc_count_ones.3

Loading...
View Options

lib/libc/stdbit/stdc_count_zeros.3

Loading...
View Options

lib/libc/stdbit/stdc_first_leading_one.3

Loading...
View Options

lib/libc/stdbit/stdc_first_leading_zero.3

Loading...
View Options

lib/libc/stdbit/stdc_first_trailing_one.3

Loading...
View Options

lib/libc/stdbit/stdc_first_trailing_zero.3

Loading...
View Options

lib/libc/stdbit/stdc_has_single_bit.3

Loading...
View Options

lib/libc/stdbit/stdc_leading_ones.3

Loading...
View Options

lib/libc/stdbit/stdc_leading_zeros.3

Loading...
View Options

lib/libc/stdbit/stdc_trailing_ones.3

Loading...
View Options

lib/libc/stdbit/stdc_trailing_zeros.3

Loading...