Page MenuHomeFreeBSD

virtual_oss: Clean up rcorder
ClosedPublic

Authored by christos on Oct 10 2025, 11:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 16, 5:49 AM
Unknown Object (File)
Tue, Dec 16, 5:49 AM
Unknown Object (File)
Mon, Dec 8, 2:54 AM
Unknown Object (File)
Wed, Dec 3, 7:52 AM
Unknown Object (File)
Wed, Dec 3, 6:59 AM
Unknown Object (File)
Sun, Nov 30, 6:59 PM
Unknown Object (File)
Nov 2 2025, 9:53 PM
Unknown Object (File)
Nov 1 2025, 5:58 PM
Subscribers

Details

Summary

sndiod is part of audio/sndio, so we should avoid referencing a port
utility from base.

We should also require NETWORKING for the service to start, since
virtual_oss can be configured to send audio through the network.

Sponsored by: The FreeBSD Foundation
MFC after: 1 day

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 67696
Build 64579: arc lint + arc unit

Event Timeline

While here, require DAEMON as well.

Why?

In D53019#1211338, @des wrote:

While here, require DAEMON as well.

Why?

DAEMON makes sure NETWORKING is started first, and virtual_oss can also be configured to send audio through the network, so we might want to make sure we have networking properly set up first.

The correct way to express that you need the network to be up is REQUIRE: NETWORKING.

In D53019#1211342, @des wrote:

The correct way to express that you need the network to be up is REQUIRE: NETWORKING.

I do not have any objection, just curious: isn't this almost the same as REQUIRE: DAEMON?

Also, as with sndio, we do not need networking either, but there are (rare) cases of configurations that might need it.

I do not have any objection, just curious: isn't this almost the same as REQUIRE: DAEMON?

% rcorder /etc/rc.d/* |& egrep -n 'NETWORKING|DAEMON|virtual_oss'
1:rcorder: file `/etc/rc.d/virtual_oss' is before unknown provision `sndiod'
62:/etc/rc.d/virtual_oss
88:/etc/rc.d/NETWORKING
141:/etc/rc.d/DAEMON

not really, no

christos retitled this revision from virtual_oss: Do not reference sndiod in rcorder to virtual_oss: Clean up rcorder.Oct 10 2025, 12:55 PM
christos edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Oct 10 2025, 12:58 PM

The short MFC time is so that it can land in BETA1.

This revision was automatically updated to reflect the committed changes.