Page MenuHomeFreeBSD
Differential D53020

audio/sndio: Add virtual_oss to rcorder
ClosedPublic
Actions

Authored by christos on Oct 10 2025, 11:55 AM.
Tags
None
Referenced Files
F174945134: D53020.id163920.diff
Wed, Oct 7, 3:15 AM
F174943957: D53020.id163976.diff
Wed, Oct 7, 3:05 AM
F174859462: D53020.diff
Tue, Oct 6, 2:36 PM
Unknown Object (File)
Sun, Oct 4, 5:48 PM
Unknown Object (File)
Sun, Oct 4, 5:45 PM
Unknown Object (File)
Thu, Oct 1, 3:46 PM
Unknown Object (File)
Thu, Oct 1, 2:38 PM
Unknown Object (File)
Tue, Sep 29, 11:11 PM
View All Files
Subscribers
None

Details

Reviewers
arrowd
des
0mp
emaste
Commits
R11:47a060bc66e9: audio/sndio: Add virtual_oss to rcorder
Summary

Because virtual_oss(8) might be configured to use sndio devices, we
should make sure that sndiod starts before the virtual_oss service.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos requested review of this revision.Oct 10 2025, 11:55 AM
christos created this revision.
Harbormaster completed remote builds in B67694: Diff 163920.Oct 10 2025, 11:56 AM
christos added a reviewer: 0mp.Oct 10 2025, 11:57 AM
arrowd added a comment.Oct 10 2025, 12:52 PM

Doesn't virtual_oss rc script already contain BEFORE: sndiod? This forms a cycle.

christos added a comment.Oct 10 2025, 12:56 PM
In D53020#1211354, @arrowd wrote:

Doesn't virtual_oss rc script already contain BEFORE: sndiod? This forms a cycle.

See D53019.

des added inline comments.Oct 10 2025, 12:58 PM
audio/sndio/files/sndiod.in
5

Is BEFORE: DAEMON really necessary? I would think BEFORE: virtual_oss would be sufficient?

christos added inline comments.Oct 10 2025, 12:59 PM
audio/sndio/files/sndiod.in
5

I am not the author of this port, so I do not really know why BEFORE: DAEMON is there in the first place. Do you think we can remove it?

des accepted this revision.Oct 10 2025, 1:02 PM
des added inline comments.
audio/sndio/files/sndiod.in
5

Just leave it in then.

This revision is now accepted and ready to land.Oct 10 2025, 1:02 PM
arrowd added inline comments.Oct 10 2025, 1:03 PM
audio/sndio/files/sndiod.in
5

It can be easily verified by running rcorder /etc/rc.d/* /usr/local/etc/rc.d/* for both variants and then comparing the output.

emaste accepted this revision.Oct 10 2025, 1:07 PM
christos marked 3 inline comments as done.Oct 10 2025, 1:09 PM
christos added a comment.Oct 10 2025, 3:43 PM

@arrowd Is it ready?

arrowd accepted this revision.Oct 10 2025, 4:34 PM

LGTM, yes.

Closed by commit R11:47a060bc66e9: audio/sndio: Add virtual_oss to rcorder (authored by christos). · Explain WhyOct 10 2025, 8:33 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: R11:47a060bc66e9: audio/sndio: Add virtual_oss to rcorder.

Revision Contents
Changeset List

PathSize
audio/
sndio/
1 line
files/
2 lines

Diff 163976

View Options

audio/sndio/Makefile

Loading...
View Options

audio/sndio/files/sndiod.in

Loading...