virtual_oss: Clean up rcorder
ClosedPublic
Actions

Authored by christos on Fri, Oct 10, 11:53 AM.

Details

Reviewers

markj
emaste
0mp
des

Commits

rG2a6c17544e00: virtual_oss: Clean up rcorder
rG188ddc15e546: virtual_oss: Clean up rcorder

Summary

sndiod is part of audio/sndio, so we should avoid referencing a port
utility from base.

We should also require NETWORKING for the service to start, since
virtual_oss can be configured to send audio through the network.

Sponsored by: The FreeBSD Foundation
MFC after: 1 day

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Fri, Oct 10, 11:53 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 10, 11:53 AM

christos requested review of this revision.Fri, Oct 10, 11:53 AM

Harbormaster completed remote builds in B67693: Diff 163919.Fri, Oct 10, 11:53 AM

While here, require DAEMON as well.

Why?

In D53019#1211338, @des wrote:

While here, require DAEMON as well.

Why?

DAEMON makes sure NETWORKING is started first, and virtual_oss can also be configured to send audio through the network, so we might want to make sure we have networking properly set up first.

The correct way to express that you need the network to be up is REQUIRE: NETWORKING.

In D53019#1211342, @des wrote:

The correct way to express that you need the network to be up is REQUIRE: NETWORKING.

I do not have any objection, just curious: isn't this almost the same as REQUIRE: DAEMON?

Also, as with sndio, we do not need networking either, but there are (rare) cases of configurations that might need it.

I do not have any objection, just curious: isn't this almost the same as REQUIRE: DAEMON?

% rcorder /etc/rc.d/* |& egrep -n 'NETWORKING|DAEMON|virtual_oss'
1:rcorder: file `/etc/rc.d/virtual_oss' is before unknown provision `sndiod'
62:/etc/rc.d/virtual_oss
88:/etc/rc.d/NETWORKING
141:/etc/rc.d/DAEMON

not really, no

christos retitled this revision from virtual_oss: Do not reference sndiod in rcorder to virtual_oss: Clean up rcorder.Fri, Oct 10, 12:55 PM

christos edited the summary of this revision. (Show Details)

Address des@ comments.

Harbormaster completed remote builds in B67696: Diff 163925.Fri, Oct 10, 12:56 PM

christos mentioned this in D53020: audio/sndio: Add virtual_oss to rcorder.Fri, Oct 10, 12:56 PM

des accepted this revision.Fri, Oct 10, 12:58 PM

This revision is now accepted and ready to land.Fri, Oct 10, 12:58 PM

The short MFC time is so that it can land in BETA1.

emaste accepted this revision.Fri, Oct 10, 1:05 PM

markj accepted this revision.Fri, Oct 10, 1:06 PM

Closed by commit rG188ddc15e546: virtual_oss: Clean up rcorder (authored by christos). · Explain WhyFri, Oct 10, 1:07 PM