pw: Add a metalog output mode
ClosedPublic
Actions

Authored by markj on Sep 16 2025, 11:29 PM.

Details

Reviewers

bapt
emaste

Commits

rG806af8240801: pw: Add a metalog output mode
rG1efb9810ba8c: pw: Add a metalog output mode
rG182ed3c0755f: pw: Add a metalog output mode

Summary

When creating OS images as a non-root user, it may be useful to
pre-create users in the staged tree. The useradd operation adds files
to the new user's home directory, copied from the skeleton directory
(/usr/share/skel), which makes it inconvient for use in this scenario.

To cover this gap, this change adds a new -M <metalog> option to pw's
useradd operation, causing pw to add mtree entries for newly added
files.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Sep 16 2025, 11:29 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptSep 16 2025, 11:29 PM

markj requested review of this revision.Sep 16 2025, 11:29 PM

Harbormaster completed remote builds in B67107: Diff 162213.Sep 16 2025, 11:29 PM

markj added a parent revision: D52588: pw: Use copy_file_range() when copying skeleton files.Sep 16 2025, 11:29 PM

emaste accepted this revision.Sep 18 2025, 2:10 AM

emaste added inline comments.

usr.sbin/pw/pw.c
259–260	maybe worth doing this bugfix separately so we can MFC it in advance of other changes here?
usr.sbin/pw/pw_utils.c
97	This `_` convention seems a bit unusual

This revision is now accepted and ready to land.Sep 18 2025, 2:10 AM

bapt accepted this revision.Sep 18 2025, 6:43 AM

bapt added inline comments.

usr.sbin/pw/pw_utils.c
124	I wonder if it won't be smart to move the metalog_emit to libutil later so it can be used by other tools

markj marked 2 inline comments as done.Sep 18 2025, 10:26 PM

markj added inline comments.

usr.sbin/pw/pw_utils.c
97	Ok, I will rename it to metalog_emit_record().
116	I'm not handling file flags here. I don't think pw sets any, but we should handle that anyway.
124	Maybe, yeah. It's a fairly simple routine though, and different consumers have different requirements (e.g., uname/gname vs. uid/gid, some consumers want to flock the metalog, ...).