Page MenuHomeFreeBSD
Differential D52455

release: Prepare GCE cloudware images for building as non-root
ClosedPublic
Actions

Authored by markj on Tue, Sep 9, 2:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 25, 9:38 PM
Unknown Object (File)
Thu, Sep 25, 5:38 PM
Unknown Object (File)
Wed, Sep 24, 8:34 PM
Unknown Object (File)
Tue, Sep 23, 6:36 PM
Unknown Object (File)
Tue, Sep 23, 4:06 PM
Unknown Object (File)
Mon, Sep 22, 5:30 AM
Unknown Object (File)
Mon, Sep 22, 12:26 AM
Unknown Object (File)
Sun, Sep 21, 3:59 PM
View All 15 Files
Subscribers
cperciva
imp
jrtc27

Details

Reviewers
emaste
cperciva
Group Reviewers
releng
Commits
rGf1995d6fc13f: release: Prepare GCE cloudware images for building as non-root
Summary
  • Avoid mounting devfs just to list packages and fetch distfiles.
  • Add metalog entries.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 67049
Build 63932: arc lint + arc unit

Event Timeline

markj created this revision.Tue, Sep 9, 2:54 PM
Herald added subscribers: jrtc27, imp. · View Herald TranscriptTue, Sep 9, 2:54 PM
markj requested review of this revision.Tue, Sep 9, 2:54 PM
Harbormaster completed remote builds in B66927: Diff 161794.Tue, Sep 9, 2:54 PM
markj added a parent revision: D52454: release: Prepare oracle cloudware images for non-root builds.Tue, Sep 9, 2:54 PM
markj added a child revision: D52456: release: Prepare Vagrant cloudware images for building as non-root.
cperciva added a subscriber: cperciva.Tue, Sep 9, 3:37 PM
cperciva added inline comments.
release/tools/gce.conf
99

s/ports/src/

105

Probably want to set DISTDIR=${DESTDIR}/usr/ports/distfiles here just in case there's environmental pollution which would send the distfiles into the wrong place.

cperciva added inline comments.Wed, Sep 10, 12:35 AM
release/tools/gce.conf
98

Actually thinking about this a bit more -- the src.txz and ports.txz tarballs will go away at some point with pkgbase. Can we copy the trees directly rather than going through those? (Obviously we have a src tree at this point; I'm not immediately sure if we're guaranteed to have a ports tree mounted when this code runs but that's probably easily achievable.)

emaste added inline comments.Wed, Sep 10, 1:11 AM
release/tools/gce.conf
98

I think it's reasonable to do that, but separately from this change. But, is the change here just fxJ to -xfJ?

cperciva added inline comments.Wed, Sep 10, 1:26 AM
release/tools/gce.conf
98

Yeah I have no problem with that change happening later. Just thought about it while looking at these bits.

emaste requested changes to this revision.Mon, Sep 15, 2:03 PM

Recording "request changes" for @cperciva's comment

This revision now requires changes to proceed.Mon, Sep 15, 2:03 PM
markj updated this revision to Diff 162071.Mon, Sep 15, 3:38 PM

Remove an inadvertent change to a tar invocation.

Harbormaster completed remote builds in B67049: Diff 162071.Mon, Sep 15, 3:38 PM
markj updated this revision to Diff 162072.Mon, Sep 15, 3:40 PM
markj marked 3 inline comments as done.

Set DISTDIR when fetching ports distfiles.

Harbormaster completed remote builds in B67050: Diff 162072.Mon, Sep 15, 3:40 PM
cperciva accepted this revision.Mon, Sep 15, 5:12 PM
emaste accepted this revision.Mon, Sep 15, 9:00 PM
This revision is now accepted and ready to land.Mon, Sep 15, 9:00 PM
Closed by commit rGf1995d6fc13f: release: Prepare GCE cloudware images for building as non-root (authored by markj). · Explain WhyTue, Sep 16, 8:51 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGf1995d6fc13f: release: Prepare GCE cloudware images for building as non-root.

Revision Contents
Changeset List

PathSize
release/
tools/
15 lines

Diff 162071

View Options

release/tools/gce.conf

Loading...