Paths

Table of Contentst

Differential D52296

tcp: micro-optimize SYN-cookie expansion
ClosedPublic
Actions

Authored by tuexen on Aug 30 2025, 10:32 PM.

Tags

None

Referenced Files

	F170892853: D52296.id.diff
	Mon, Sep 7, 9:12 AM

	F170867971: D52296.id161342.diff
	Mon, Sep 7, 3:47 AM

	F170856341: D52296.id161349.diff
	Mon, Sep 7, 2:01 AM

	F170856304: D52296.id161275.diff
	Mon, Sep 7, 2:00 AM

	Unknown Object (File)
	Sun, Sep 6, 11:06 AM

	Unknown Object (File)
	Sat, Sep 5, 5:34 AM

	Unknown Object (File)
	Fri, Sep 4, 5:23 AM

	Unknown Object (File)
	Thu, Sep 3, 3:02 AM

Subscribers

Details

Reviewers

rscheff
cc
peter.lei_ieee.org
nickbanks_netflix.com
lstewart
glebius

Group Reviewers

Commits

rG5d65c9eeb805: tcp: micro-optimize SYN-cookie expansion
rG341d1aabc13e: tcp: micro-optimize SYN-cookie expansion

Summary

Only compute wscale when it is actually used.
No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Aug 30 2025, 10:32 PM

Herald added a reviewer: transport. · View Herald TranscriptAug 30 2025, 10:32 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Aug 30 2025, 10:32 PM

rscheff accepted this revision.Sep 1 2025, 6:42 AM

This revision is now accepted and ready to land.Sep 1 2025, 6:42 AM

glebius added inline comments.Sep 1 2025, 5:02 PM

sys/netinet/tcp_syncache.c
2327	I'd suggest to make it u_int. Negative right operand of << is undefined behavior. I know we don't got into negative here, but using unsigned operand would make it tidier.

Use u_int instead of int as the type for wscale as suggested by glebius@.

This revision now requires review to proceed.Sep 1 2025, 8:45 PM

glebius accepted this revision.Sep 1 2025, 10:13 PM

This revision is now accepted and ready to land.Sep 1 2025, 10:13 PM

Closed by commit rG341d1aabc13e: tcp: micro-optimize SYN-cookie expansion (authored by tuexen). · Explain WhySep 1 2025, 10:24 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rG341d1aabc13e: tcp: micro-optimize SYN-cookie expansion.

tuexen added a commit: rG5d65c9eeb805: tcp: micro-optimize SYN-cookie expansion.Sep 8 2025, 10:02 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

14 lines

Diff 161349

sys/netinet/tcp_syncache.c

Loading...