Page MenuHomeFreeBSD
Differential D51804

Mk/Uses/cargo.mk: Define ar and linker in RUSTFLAGS
ClosedPublic
Actions

Authored by michaelo on Aug 7 2025, 7:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 20, 2:32 PM
Unknown Object (File)
Wed, May 20, 1:33 AM
Unknown Object (File)
Sun, May 17, 7:37 AM
Unknown Object (File)
Sat, May 16, 11:48 PM
Unknown Object (File)
Fri, May 15, 3:30 PM
Unknown Object (File)
Fri, May 15, 12:15 AM
Unknown Object (File)
Thu, May 14, 9:14 PM
Unknown Object (File)
Thu, May 14, 5:45 PM
View All 81 Files
Subscribers
antoine
mikael

Details

Reviewers
jrm
tijl
otis
mikael
Group Reviewers
rust
Commits
R11:0ab0b75c82df: Mk/Uses/cargo.mk: Define ar and linker in RUSTFLAGS
Summary

Otherwise base system ar and cc are always used.

PR: 283529
Approved by: jrm (mentor), otis (mentor)
MFH: 2025Q3

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 66507
Build 63390: arc lint + arc unit

Event Timeline

michaelo requested review of this revision.Aug 7 2025, 7:51 PM
michaelo created this revision.
Harbormaster completed remote builds in B66072: Diff 159994.Aug 7 2025, 7:51 PM
michaelo added a reviewer: rust.Aug 7 2025, 7:51 PM
michaelo added a comment.Aug 22 2025, 9:54 AM

Anyone willing to review?

mikael added a subscriber: mikael.Aug 22 2025, 12:37 PM

Are any ports broken without (or with) this patch?
I really have no clue why this patch is (or isn't) necessary.

Feel free to commit if it doesn't cause breakage.

michaelo added a comment.Aug 22 2025, 12:40 PM
In D51804#1190231, @mikael wrote:

Are any ports broken without (or with) this patch?
I really have no clue why this patch is (or isn't) necessary.

This we need to ask @tijl. I'd understand that one may wants to use gold or another linker for specific purposes.

Feel free to commit if it doesn't cause breakage.

I can't commit w/o approval formally.

mikael added a comment.Aug 22 2025, 12:43 PM

You have my approval if it doesn't break ports (you can ask for an exp-run)

michaelo added a comment.Aug 22 2025, 12:45 PM
In D51804#1190233, @mikael wrote:

You have my approval if it doesn't break ports (you can ask for an exp-run)

Then let me request is, rather be safe than sorry.

michaelo edited the summary of this revision. (Show Details)Aug 22 2025, 12:53 PM
tijl added a comment.Aug 22 2025, 5:01 PM

It's just to respect AR and CC. I discovered this on a system where everything is built with ports llvm (no base system compiler installed).

michaelo added a comment.Aug 22 2025, 5:02 PM
In D51804#1190438, @tijl wrote:

It's just to respect AR and CC. I discovered this on a system where everything is built with ports llvm (no base system compiler installed).

This is more or less what I have assumed. Another toolchain...

michaelo updated this revision to Diff 160936.Aug 25 2025, 3:22 PM

Rebase

Harbormaster completed remote builds in B66507: Diff 160936.Aug 25 2025, 3:22 PM
michaelo added a subscriber: antoine.Aug 26 2025, 7:46 AM

@antoine is performing exp-run...

michaelo added a comment.Aug 29 2025, 10:14 PM

@mikael, exp-run is complete. No related failures. Are we good to approve and merge this one?

mikael accepted this revision.Aug 30 2025, 6:30 AM
This revision is now accepted and ready to land.Aug 30 2025, 6:30 AM
michaelo added a comment.Aug 31 2025, 7:46 PM

Waiting for a format approval from mentors.

otis accepted this revision.Aug 31 2025, 8:03 PM

Because rust is OK, so am I.

jrm accepted this revision.Aug 31 2025, 8:05 PM

Same.

Closed by commit R11:0ab0b75c82df: Mk/Uses/cargo.mk: Define ar and linker in RUSTFLAGS (authored by tijl, committed by michaelo). · Explain WhyAug 31 2025, 9:07 PM
This revision was automatically updated to reflect the committed changes.
michaelo added a commit: R11:0ab0b75c82df: Mk/Uses/cargo.mk: Define ar and linker in RUSTFLAGS.

Revision Contents
Changeset List

PathSize
Mk/
Uses/
2 lines

Diff 160936

View Options

Mk/Uses/cargo.mk

Loading...