Move check for (done_ccb == NULL)
ClosedPublic
Actions

Authored by slm on Apr 25 2016, 10:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Oct 5, 10:33 AM

	Unknown Object (File)
	Sat, Oct 4, 11:35 PM

	Unknown Object (File)
	Sat, Oct 4, 3:34 PM

	Unknown Object (File)
	Sat, Oct 4, 8:01 AM

	Unknown Object (File)
	Mon, Sep 22, 10:34 PM

	Unknown Object (File)
	Tue, Sep 16, 2:31 AM

	Unknown Object (File)
	Sat, Sep 13, 2:08 AM

	Unknown Object (File)
	Aug 25 2025, 8:12 PM

View All Files

Subscribers

imp

Details

Reviewers

scottl
ken
ambrisko
allanjude
asomers
mav

Commits

rS299272: done_ccb pointer can be used if it is NULL.

Summary

done_ccb pointer can be used if it is NULL. To prevent this, move check for done_ccb == NULL to before done_ccb is used in the mprsas_stop_unit_done().

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

slm updated this revision to Diff 15601.Apr 25 2016, 10:41 PM

slm retitled this revision from to Move check for (done_ccb == NULL).

slm updated this object.

slm edited the test plan for this revision. (Show Details)

slm added reviewers: ken, scottl, ambrisko, asomers, mav, allanjude.

slm set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptApr 25 2016, 10:41 PM

asomers accepted this revision.Apr 25 2016, 11:03 PM

asomers edited edge metadata.

This revision is now accepted and ready to land.Apr 25 2016, 11:03 PM

Looks good.

Closed by commit rS299272: done_ccb pointer can be used if it is NULL. (authored by slm). · Explain WhyMay 9 2016, 4:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

mpr/

mpr_sas_lsi.c

6 lines

Diff 16070

View Options

head/sys/dev/mpr/mpr_sas_lsi.c

Move check for (done_ccb == NULL)ClosedPublicActions