Page MenuHomeFreeBSD
Differential D6099

Move check for (done_ccb == NULL)
ClosedPublic
Actions

Authored by slm on Apr 25 2016, 10:41 PM.
Tags
None
Referenced Files
F156530870: D6099.diff
Thu, May 14, 11:28 AM
Unknown Object (File)
Fri, Apr 24, 6:51 AM
Unknown Object (File)
Thu, Apr 23, 11:56 PM
Unknown Object (File)
Thu, Apr 23, 12:52 AM
Unknown Object (File)
Tue, Apr 21, 11:19 AM
Unknown Object (File)
Mon, Apr 20, 8:49 AM
Unknown Object (File)
Wed, Apr 15, 3:47 AM
Unknown Object (File)
Apr 11 2026, 11:20 PM
View All Files
Subscribers
imp

Details

Reviewers
scottl
ken
ambrisko
allanjude
asomers
mav
Commits
rS299272: done_ccb pointer can be used if it is NULL.
Summary

done_ccb pointer can be used if it is NULL. To prevent this, move check for done_ccb == NULL to before done_ccb is used in the mprsas_stop_unit_done().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3449
Build 3488: arc lint + arc unit

Event Timeline

slm updated this revision to Diff 15601.Apr 25 2016, 10:41 PM
slm retitled this revision from to Move check for (done_ccb == NULL).
slm updated this object.
slm edited the test plan for this revision. (Show Details)
slm added reviewers: ken, scottl, ambrisko, asomers, mav, allanjude.
slm set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptApr 25 2016, 10:41 PM
asomers accepted this revision.Apr 25 2016, 11:03 PM
asomers edited edge metadata.
This revision is now accepted and ready to land.Apr 25 2016, 11:03 PM
ken accepted this revision.Apr 26 2016, 5:55 PM
ken edited edge metadata.

Looks good.

Closed by commit rS299272: done_ccb pointer can be used if it is NULL. (authored by slm). · Explain WhyMay 9 2016, 4:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
mpr/
6 lines

Diff 15601

View Options

sys/dev/mpr/mpr_sas_lsi.c

Loading...