bsd.mkopt.mk: Undefine __REQUIRED_OPTIONS
AbandonedPublic
Actions

Authored by des on Fri, Aug 8, 1:36 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Aug 29, 2:31 AM

	Unknown Object (File)
	Thu, Aug 28, 8:56 PM

	Unknown Object (File)
	Tue, Aug 26, 4:26 AM

	Unknown Object (File)
	Sun, Aug 24, 1:55 AM

	Unknown Object (File)
	Sat, Aug 23, 1:24 PM

	Unknown Object (File)
	Fri, Aug 22, 10:20 PM

	Unknown Object (File)
	Mon, Aug 18, 4:47 PM

	Unknown Object (File)
	Mon, Aug 18, 1:51 PM

Subscribers

Details

Reviewers

None

Group Reviewers

srcmgr

Summary

The other three (__DEFAULT_{YES,NO,DEPENDENT}_OPTIONS) were already
being undefined, but this one got missed.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 66106
Build 62989: arc lint + arc unit

Event Timeline

des created this revision.Fri, Aug 8, 1:36 PM

Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptFri, Aug 8, 1:36 PM

des requested review of this revision.Fri, Aug 8, 1:36 PM

Harbormaster completed remote builds in B66106: Diff 160055.Fri, Aug 8, 1:36 PM

des added a child revision: D51827: bsd.mkopt.mk: Prepare a list of all build options.Fri, Aug 8, 1:37 PM

tools/build/options/makeman tries to extract the value of __REQUIRED_OPTIONS using make -V. Are you sure this doesn't break that?

Ah, it does, but we should really find a different way of getting that information (or even hardcode it in the script). Not undefining __REQUIRED_OPTIONS here means we can only use it in one place; since we already use it in src.opts.mk, we can't ever use it in bsd.opts.mk.

des mentioned this in D51827: bsd.mkopt.mk: Prepare a list of all build options.Fri, Aug 8, 2:28 PM

Folded into D51827 which also includes a fix for makeman.