Page MenuHomeFreeBSD

bsd.mkopt.mk: Undefine __REQUIRED_OPTIONS
AbandonedPublic

Authored by des on Aug 8 2025, 1:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 16, 2:39 AM
Unknown Object (File)
Sun, Nov 16, 2:39 AM
Unknown Object (File)
Sun, Nov 16, 2:36 AM
Unknown Object (File)
Wed, Oct 29, 1:30 AM
Unknown Object (File)
Oct 15 2025, 11:30 PM
Unknown Object (File)
Oct 9 2025, 8:06 PM
Unknown Object (File)
Oct 9 2025, 8:06 PM
Unknown Object (File)
Oct 9 2025, 5:22 PM

Details

Reviewers
None
Group Reviewers
srcmgr
Summary

The other three (__DEFAULT_{YES,NO,DEPENDENT}_OPTIONS) were already
being undefined, but this one got missed.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 66106
Build 62989: arc lint + arc unit

Event Timeline

des requested review of this revision.Aug 8 2025, 1:36 PM

tools/build/options/makeman tries to extract the value of __REQUIRED_OPTIONS using make -V. Are you sure this doesn't break that?

Ah, it does, but we should really find a different way of getting that information (or even hardcode it in the script). Not undefining __REQUIRED_OPTIONS here means we can only use it in one place; since we already use it in src.opts.mk, we can't ever use it in bsd.opts.mk.

Folded into D51827 which also includes a fix for makeman.