Explicitly hand off ownership of accepted sockets to the
portal::handle_connection method.
Sponsored by: Chelsio Communications
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 65956 Build 62839: arc lint + arc unit
Event Timeline
| usr.sbin/ctld/iscsi.cc | ||
|---|---|---|
| 419 | The existence of lines like this one almost defeats the purpose of the patch. But I suppose the patch still represents incremental progress, and this part could be improved in the future. | |
| usr.sbin/ctld/iscsi.cc | ||
|---|---|---|
| 419 | The conn structure is something from libiscsiutil that is shared with iscsid and iscsictl for the initiator side. conn_fd still retains "ownership" of the fd and auto-closes on destruction at least. If the other consumers switch to C++ in some form (or at least libiscsiutil uses a C++ class for its connection object), then the fd could be moved into this, yes. And probably conn_fd would not even be needed in that case. This pattern is realized a bit better on the NVMe side, though even there it is somewhat imperfect as libnvmf still works with C structures. | |