Page MenuHomeFreeBSD

krb5: don't install libdb manual pages
ClosedPublic

Authored by ivy on Jul 19 2025, 2:50 AM.
Tags
None
Referenced Files
F131734457: D51418.id158769.diff
Fri, Oct 10, 6:10 PM
F131717972: D51418.diff
Fri, Oct 10, 2:50 PM
Unknown Object (File)
Thu, Oct 9, 4:48 PM
Unknown Object (File)
Thu, Oct 9, 4:48 PM
Unknown Object (File)
Thu, Oct 9, 4:48 PM
Unknown Object (File)
Thu, Oct 9, 4:48 PM
Unknown Object (File)
Thu, Oct 9, 4:48 PM
Unknown Object (File)
Thu, Oct 9, 4:48 PM
Subscribers

Details

Summary

This version of libdb is private to Kerberos and not intended for
external use, so avoid installing manual pages that may conflict
with another version of libdb.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65574
Build 62457: arc lint + arc unit

Event Timeline

ivy requested review of this revision.Jul 19 2025, 2:50 AM
krb5/plugins/kdb/db2/Makefile
49

This line is redundant.

krb5/plugins/kdb/db2/Makefile
14

<bsd.lib.mk> already does this.

add the manpages to ObsoleteFiles

since WITH_MITKRB5 became the default a few days ago, it's likely people have
these installed now. note that they aren't OptionalObsoleteFiles because they
should never be installed regardless of which (if any) Kerberos you choose.

remove redundant .SUFFIXES

ivy marked an inline comment as done.Jul 25 2025, 8:03 AM
ivy added inline comments.
krb5/plugins/kdb/db2/Makefile
14

but is this still required for the .include on line 30 to work? or is KRB5_SRCTOP set in the environment?

(i can run a test build but since nearly all the krb5 makefiles have this include, it might make sense to do that in a separate change.)

des added inline comments.
krb5/plugins/kdb/db2/Makefile
14

move that other .include to the bottom, it does not need to precede the CFLAGS line since KRB5_DIR is not expanded when CFLAGS is set but when it is used.

This revision is now accepted and ready to land.Jul 25 2025, 12:11 PM
This revision now requires review to proceed.Jul 25 2025, 1:18 PM
This revision is now accepted and ready to land.Jul 25 2025, 1:43 PM
This revision was automatically updated to reflect the committed changes.